Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752522AbdLGWXY (ORCPT ); Thu, 7 Dec 2017 17:23:24 -0500 Received: from mail.us.es ([193.147.175.20]:33284 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752296AbdLGWXV (ORCPT ); Thu, 7 Dec 2017 17:23:21 -0500 Date: Thu, 7 Dec 2017 23:23:16 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Arnd Bergmann Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Xin Long , Vasily Averin , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: fix clusterip_net_exit build regression Message-ID: <20171207222316.GC1329@salvia> References: <20171207132636.259066-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171207132636.259066-1-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 439 Lines: 11 On Thu, Dec 07, 2017 at 02:26:09PM +0100, Arnd Bergmann wrote: > The added check produces a build error when CONFIG_PROC_FS is > disabled: > > net/ipv4/netfilter/ipt_CLUSTERIP.c: In function 'clusterip_net_exit': > net/ipv4/netfilter/ipt_CLUSTERIP.c:822:28: error: 'cn' undeclared (first use in this function) > > This moves the variable declaration out of the #ifdef to make it > available to the WARN_ON_ONCE(). Applied, thanks Arnd.