Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752430AbdLGWYe (ORCPT ); Thu, 7 Dec 2017 17:24:34 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:39335 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001AbdLGWYc (ORCPT ); Thu, 7 Dec 2017 17:24:32 -0500 X-Google-Smtp-Source: AGs4zMZShxnyfi42+j1nwy15MIwgFOEJqr4JmU12ISbFTJd3dHh+ZgcemrbKV7Pe9mpHqBZ243r3wEFg533dwPt99J0= MIME-Version: 1.0 In-Reply-To: <20171207181306.5623-2-deepa.kernel@gmail.com> References: <20171207181306.5623-1-deepa.kernel@gmail.com> <20171207181306.5623-2-deepa.kernel@gmail.com> From: Arnd Bergmann Date: Thu, 7 Dec 2017 23:24:31 +0100 X-Google-Sender-Auth: aGexO2bHLJcx19JCDWtEwsC2h7Y Message-ID: Subject: Re: [PATCH v4 1/4] uinput: Use monotonic times for uinput timestamps. To: Deepa Dinamani Cc: Dmitry Torokhov , "open list:HID CORE LAYER" , Linux Kernel Mailing List , Peter Hutterer , y2038 Mailman List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 665 Lines: 18 On Thu, Dec 7, 2017 at 7:13 PM, Deepa Dinamani wrote: > struct timeval which is part of struct input_event to > maintain the event times is not y2038 safe. > > Real time timestamps are also not ideal for input_event > as this time can go backwards as noted in the patch > a80b83b7b8 by John Stultz. > > The patch switches the timestamps to use monotonic time > from realtime time. This is assuming no one is using > absolute times from these timestamps. > > The structure to maintain input events will be changed > in a different patch. > > Signed-off-by: Deepa Dinamani Reviewed-by: Arnd Bergmann