Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbdLGXDU (ORCPT ); Thu, 7 Dec 2017 18:03:20 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:46003 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752151AbdLGXDS (ORCPT ); Thu, 7 Dec 2017 18:03:18 -0500 X-Google-Smtp-Source: AGs4zMaQZ03HRf/+kVf7uU6mp/S8R0PJ5d9g+VlLSAmwqPMXOoYpEbDIV3DuTKK4xbOvLPaKGOkjXQ== From: Vasyl Gomonovych To: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, gomonovych@gmail.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH] fs/seq_file: Fix warning of passing zero to 'PTR_ERR' Date: Fri, 8 Dec 2017 00:03:07 +0100 Message-Id: <1512687788-27172-1-git-send-email-gomonovych@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 632 Lines: 24 p could be NULL and passing into PTR_ERR Signed-off-by: Vasyl Gomonovych --- fs/seq_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/seq_file.c b/fs/seq_file.c index 4be761c..8b700b9 100644 --- a/fs/seq_file.c +++ b/fs/seq_file.c @@ -262,8 +262,8 @@ ssize_t seq_read(struct file *file, char __user *buf, size_t size, loff_t *ppos) size_t offs = m->count; loff_t next = pos; p = m->op->next(m, p, &next); - if (!p || IS_ERR(p)) { - err = PTR_ERR(p); + if (IS_ERR(p)) { + err = (!p ? -EFAULT : PTR_ERR(p)); break; } err = m->op->show(m, p); -- 1.9.1