Date: Thu, 7 Dec 2017 23:23:26 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Vasyl Gomonovych <gomonovych@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/seq_file: Fix warning of passing zero to 'PTR_ERR'
Message-ID: <20171207232326.GI21978@ZenIV.linux.org.uk>
References: <1512687788-27172-1-git-send-email-gomonovych@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1512687788-27172-1-git-send-email-gomonovych@gmail.com>
User-Agent: Mutt/1.9.0 (2017-09-02)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 834
Lines: 24

On Fri, Dec 08, 2017 at 12:03:07AM +0100, Vasyl Gomonovych wrote:
> p could be NULL and passing into PTR_ERR
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
>  fs/seq_file.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/seq_file.c b/fs/seq_file.c
> index 4be761c..8b700b9 100644
> --- a/fs/seq_file.c
> +++ b/fs/seq_file.c
> @@ -262,8 +262,8 @@ ssize_t seq_read(struct file *file, char __user *buf, size_t size, loff_t *ppos)
>  		size_t offs = m->count;
>  		loff_t next = pos;
>  		p = m->op->next(m, p, &next);
> -		if (!p || IS_ERR(p)) {
> -			err = PTR_ERR(p);
> +		if (IS_ERR(p)) {
> +			err = (!p ? -EFAULT : PTR_ERR(p));

What does it fix, if I might ask?  And while we are at it, would
you mind explaining the reasoning behind that change?  Or, say,
testing done to it...