Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbdLHAUA (ORCPT ); Thu, 7 Dec 2017 19:20:00 -0500 Received: from mail-vk0-f42.google.com ([209.85.213.42]:41549 "EHLO mail-vk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001AbdLHAT6 (ORCPT ); Thu, 7 Dec 2017 19:19:58 -0500 X-Google-Smtp-Source: AGs4zMYrBU9CiDitO3paPXFjMy7iZP2X6XmueXjqzRxt/+LVNvMzU3jXP2VTD9swY95NOKiId02Daual6qxrNfMR1u8= MIME-Version: 1.0 In-Reply-To: <20171207234402.GT2191@eros> References: <1512524729-16051-1-git-send-email-me@tobin.cc> <20171207234402.GT2191@eros> From: Kees Cook Date: Thu, 7 Dec 2017 16:19:56 -0800 X-Google-Sender-Auth: ct6hfVDdYwHFtWZszdNz7MSfeL4 Message-ID: Subject: Re: [PATCH] doc: convert printk-formats.txt to rst To: "Tobin C. Harding" Cc: Jonathan Corbet , Randy Dunlap , Andrew Murray , linux-doc@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 623 Lines: 20 On Thu, Dec 7, 2017 at 3:44 PM, Tobin C. Harding wrote: > Cheers Kees. FTR, changes to implement are: > > - Fix the capitalization of 'kernel'. I don't really have an opinion about which way is right. I personally don't capitalize it unless I speak about it as a single thing "The Linux Kernel". In this case I just noticed you had mixed usage. > - Add ESCAPE_* flags back into kernel-docs in lib/vsprintf.c I actually meant each of the sections. Several of the formats have per-item breakdowns that went missing in the new kernel-doc (ESCAPE_* was just an example). -Kees -- Kees Cook Pixel Security