Message-ID: <5A29DF39.9080305@huawei.com>
Date: Fri, 8 Dec 2017 08:39:21 +0800
From: alex chen <alex.chen@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Ben Hutchings <ben.hutchings@codethink.co.uk>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        piaojun <piaojun@huawei.com>, Joseph Qi <jiangqi903@gmail.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Changwei Ge <ge.changwei@h3c.com>, Mark Fasheh <mfasheh@versity.com>,
        Joel Becker <jlbec@evilplan.org>, Junxiao Bi <junxiao.bi@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4.4 13/16] ocfs2: should wait dio before inode lock in
 ocfs2_setattr()
References: <20171122101110.784746358@linuxfoundation.org>   <20171122101111.411869812@linuxfoundation.org>  <1512488994.18523.173.camel@codethink.co.uk> <5A2741B2.4040509@huawei.com> <1512671158.18523.187.camel@codethink.co.uk>
In-Reply-To: <1512671158.18523.187.camel@codethink.co.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1987
Lines: 66


On 2017/12/8 2:25, Ben Hutchings wrote:
> On Wed, 2017-12-06 at 09:02 +0800, alex chen wrote:
>> Hi Ben,
>>
>> Thanks for your reply.
>>
>> On 2017/12/5 23:49, Ben Hutchings wrote:
>>> On Wed, 2017-11-22 at 11:12 +0100, Greg Kroah-Hartman wrote:
>>>> 4.4-stable review patch.  If anyone has any objections, please let me know.
>>>>
>>>> ------------------
>>>>
>>>> From: alex chen <alex.chen@huawei.com>
>>>>
>>>> commit 28f5a8a7c033cbf3e32277f4cc9c6afd74f05300 upstream.
>>>>
>>>> we should wait dio requests to finish before inode lock in
>>>> ocfs2_setattr(), otherwise the following deadlock will happen:
>>>
>>> [...]
>>>
>>> I looked at the kernel-doc for inode_dio_wait():
>>>
>>> /**
>>>  * inode_dio_wait - wait for outstanding DIO requests to finish
>>>  * @inode: inode to wait for
>>>  *
>>>  * Waits for all pending direct I/O requests to finish so that we can
>>>  * proceed with a truncate or equivalent operation.
>>>  *
>>>  * Must be called under a lock that serializes taking new references
>>>  * to i_dio_count, usually by inode->i_mutex.
>>>  */
>>>
>>> Now that ocfs2_setattr() calls this outside of the inode locked region,
>>> what prevents another task adding a new dio request immediately
>>> afterward?
>>>
>>
>> In the kernel 4.6, firstly, we use the inode_lock() in do_truncate() to
>> prevent another bio to be issued from this node.
> [...]
> 
> Yes but there seems to be a race condition - after the call to
> inode_dio_wait() and before the call to inode_lock(), another dio
> request can be added.

In the truncating file situation, the lock order is as follow:
do_truncate()
 inode_lock()
 notify_change()
  ocfs2_setattr()
   inode_dio_wait()
    --here it is under the protect of inode_lock(), so another dio requests
      from another process will not be added.
   ocfs2_rw_lock()
   ocfs2_inode_lock_tracker()
    this function is used to prevent the inode from being modified by another
    nodes in the cluster
 inode_unlock()

> 
> Ben.
>