Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752523AbdLHCev (ORCPT <rfc822;w@1wt.eu>);
        Thu, 7 Dec 2017 21:34:51 -0500
Received: from mga05.intel.com ([192.55.52.43]:38310 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752307AbdLHCeu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Dec 2017 21:34:50 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,375,1508828400"; 
   d="scan'208";a="16450303"
Date: Fri, 8 Dec 2017 10:27:05 +0800
From: "Du, Changbin" <changbin.du@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: changbin.du@intel.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm, thp: introduce generic transparent huge page
 allocation interfaces
Message-ID: <20171208022704.7kcoky7si2suqelt@intel.com>
References: <1512644059-24329-1-git-send-email-changbin.du@intel.com>
 <20171207154519.df3f8218f8dbe05f95a2bc42@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171207154519.df3f8218f8dbe05f95a2bc42@linux-foundation.org>
User-Agent: NeoMutt/20171027-42-ad8712
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1099
Lines: 36


Hi Andrew,
On Thu, Dec 07, 2017 at 03:45:19PM -0800, Andrew Morton wrote:
> On Thu,  7 Dec 2017 18:54:19 +0800 changbin.du@intel.com wrote:
> 
> > From: Changbin Du <changbin.du@intel.com>
[snip]
 > -static inline void prep_transhuge_page(struct page *page) {}
> > +#define alloc_transhuge_page_vma(gfp_mask, vma, addr) NULL
> > +#define alloc_transhuge_page_nodemask(gfp_mask, preferred_nid, nmask) NULL
> > +#define alloc_transhuge_page_node(nid, gfp_maskg) NULL
> > +#define alloc_transhuge_page(gfp_mask) NULL
> 
> Ugly.  And such things can cause unused-variable warnings in calling
> code.  Whereas
> 
> static inline struct page *alloc_transhuge_page_vma(gfp_t gfp_mask,
> 			struct vm_area_struct *vma, unsigned long addr)
> {
> 	return NULL;
> }
> 
> will avoid such warnings.
>
Thanks for pointing out, I will update it.
   
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Thanks,
Changbin Du