Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbdLHDr2 (ORCPT ); Thu, 7 Dec 2017 22:47:28 -0500 Received: from mail-ma1ind01on0118.outbound.protection.outlook.com ([104.47.100.118]:15767 "EHLO IND01-MA1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752078AbdLHDr0 (ORCPT ); Thu, 7 Dec 2017 22:47:26 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dhaval.shah@softnautics.com; From: Dhaval Shah To: arnd@arndb.de, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Dhaval Shah Subject: [PATCH] misc: apds990x: Missing a blank line after declarations. Date: Fri, 8 Dec 2017 09:17:11 +0530 Message-Id: <20171208034711.17200-1-dhaval.shah@softnautics.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [219.65.63.222] X-ClientProxiedBy: MA1PR0101CA0059.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:20::21) To BM1PR0101MB1441.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:20::8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e84a96b6-28d3-4a4f-d234-08d53dee637c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4603075)(4627115)(201702281549075)(5600026)(4604075)(2017052603307);SRVR:BM1PR0101MB1441; X-Microsoft-Exchange-Diagnostics: 1;BM1PR0101MB1441;3:FMsubqzxEXxFDT4VkTNsXF3c+Sltb29qdrRUxHh54nIc9gNGPZcrOPUONosTeeMwi3yoIPykRrSZj8UvEolEBSxihuLP/0pTalalh1t2M+o2OC/88/X7tlA5M4KuyfCuINWLuglxPcZB59GWLmxqsRciGl661EvvIbIupjEfMG7lcecRcjLgurEynmnyy1X5q5vqHOpSKQj4P4BgoBasb8Cv5Y0/DK8fPC2y4EAffn4O3Doyq89YnIuGOJkSXq/K;25:tH0LnRuOu3Bg2N8r3SGIywQLxCbypfiZiZ5NmKP2wYDLt/xXrGsb7/TejTqYiam2GG+UoEjVndx0qiednxn0y5FJkeE0Gm2wIgzTzUsa2NYveD4ixvsziC3FV6Q/FKe339L7gIGY6arSseUk5zzi9zfTstpud+JVZxNGpW04z76ghL2c9I5TFJ2EZ3iKSwlBej35Ne2LT3/AzqJIT/lxiXSAL4Afnx7GjRffC97asD9AEc0N0zEZPBojZDlT9sD0ARxKbTiO7ZEWwKmnNeFW3KUhsyqxjMEnWXcnkqDGEi5GWCt7MINKDZ//rGPVRnLWBBgnyA+yeSNMVOWpg5NciQ==;31:tvmjpXvt22JATn1NQ3sXGYAjdUjx7gXqxTEo0ZbxxeACsluJtWiYnIEXS1ONkYr76w6vztN9CjRtSXnhWsu0YgFbmEseF4+yMC+K3zC9bd2/dZUy2RmgvRpbvS54J7w3nvjjT27FqnXmE5cqJHVpZt3aONXPVu+UuVeWXHu0aEDrGiaxeo+soSFAjEpWkiPlnSbqEOxMuusWAxHqQPMGLp7TI/E+xwLQ1zoS2s4tlKY= X-MS-TrafficTypeDiagnostic: BM1PR0101MB1441: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3231022)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123558100)(20161123560025)(2016111802025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6043046)(6072148)(201708071742011);SRVR:BM1PR0101MB1441;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BM1PR0101MB1441; X-Microsoft-Exchange-Diagnostics: 1;BM1PR0101MB1441;4:Av9WH3wbje+zhnrLT/HZaCvAuK6sGAh4wI0Kj6rDuQiB/h+QHcCX8dtefS7cd0N5EiwWq9m48Qb4m2CbXCN3o9ofqPI2t51Cs1H2GL0D/EjVHDg7EYZTpiJFCFBw66TSvM1bvYzFDWlZDc/mFqd6pc9V+YSAaikjPUw5vJiGz1sXKv3uiMeqCK7nBmTlmYUnL5qiUFZ59MdvoBipG3ex2MZ9VawHXD1VzJp3nsFVgayIkCwasv99v822F8QBytzQ7rugKfYcuaR48Grqd3k8MQ6m+8IOJDsoHn0vsIc/0kIVri18o0jI6j6Ic1M2EsUm X-Forefront-PRVS: 0515208626 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(39830400002)(366004)(346002)(376002)(189003)(199004)(4326008)(68736007)(16526018)(6512007)(86362001)(316002)(8676002)(2906002)(5660300001)(105586002)(106356001)(7736002)(3846002)(16586007)(6116002)(1076002)(53416004)(305945005)(6666003)(6506006)(81166006)(107886003)(50466002)(47776003)(66066001)(69596002)(33646002)(53936002)(25786009)(8936002)(51416003)(48376002)(50226002)(478600001)(6486002)(97736004)(52116002)(36756003)(81156014);DIR:OUT;SFP:1102;SCL:1;SRVR:BM1PR0101MB1441;H:piyush.sibshivalik.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BM1PR0101MB1441;23:jX1pmxPosVknVwhCqwpYk5oLxRXlmTZVksxgCgj?= =?us-ascii?Q?xssBI0ElkRFE735i1Rur38H32I4BZRfZamjJPg8/Rj3tnMIN3o7sio5O9mOq?= =?us-ascii?Q?mPkc8pyGGQ2W1qKFFzyfpnZztuQ4n4q9swmlZj7X3cy05ojCWOCl8HX7Yrfk?= =?us-ascii?Q?eKsSUhBw1iU/gO9/HUdx/HaBWLdJYMTkJgYcj+mJZutlkKLtCRRzjr493reQ?= =?us-ascii?Q?H89PHkWrEFCC9QY0qQ0AN8e7NlcryEkVvFB3VLXpcr8puC6cBjsbGy4zX+md?= =?us-ascii?Q?6ybxgqRED97aMMpR5ZWEt6bONl78zTeNbfSgBEobYTHpAOH4/2UBBrCGJvx0?= =?us-ascii?Q?NAtbeXTrAlAbGrIklaTMojV4LWiA/k07j+j78XDzVLiLmGdQ/LmnWxeNCpp2?= =?us-ascii?Q?e9vi1hZ6PYnV58BwrTQzhu4rfA3av4bVocGSb2dMBCDmVFJ5oCxeb4CHqVmX?= =?us-ascii?Q?+mufuk1As3Y2qlzR2GXLAzoF7waxfSIN1kRPAUeQgpLCyXk4nqlkpp3spdmD?= =?us-ascii?Q?I6iph74e7Tclo1h9+ZIM+Ls2bCW4WrdH/GmSfP2F2/remj115Vr3Ori5Mgmd?= =?us-ascii?Q?9CW2wfGvNYdiqNzod7oXO++M80pOmBsxEvsa0M3KXWcqWv6kHurU6akbBjgQ?= =?us-ascii?Q?cTpNrJ754aANIAhgZh+bBgk0zFlA1hZ3WpNdeXa7Q/VFbLOV51ODfvNJ0vCX?= =?us-ascii?Q?rD8BjB2Xn3OM+mlGQd4YZnVw5aBsm08dablaqxb+Oxede75oU0XV2bt9eq34?= =?us-ascii?Q?GYbIFLeo/Sz22GIHAg7nNXzvbGUwtBvhcNsXyrICYdP7NsoaV1BOYiYYmPQp?= =?us-ascii?Q?VH8EdFY/uvbxmQI2NzAjZk8dpYT320dmpxyCUEdkO/1QpHaIqDQsL0R/8jpN?= =?us-ascii?Q?UBBn9hkH0/7QSB1CSuyHHpEpibcObVj8EOMdOP4eYJfWLBUZ30llH+5omHDr?= =?us-ascii?Q?mX+Y/0LmC814f7VWU2Esq7NUuxXFGfb1poL5x5zxfqgxsusH+TSxAqITAo1G?= =?us-ascii?Q?wDbAmqIbkoOeOJ2JvSlxfEiJwOizYf7hTgZxGMrRBhfKDzhB4t5VnmrM6D9L?= =?us-ascii?Q?TFRcGUSg=3D?= X-Microsoft-Exchange-Diagnostics: 1;BM1PR0101MB1441;6:eUtW1quIk0m153wYRdIvz3lnCaumj+ZWgwb1tfUIyTbVFPfu+y8MXITKVXxLo3CEMRsGg6Fd9urvZQB5Duh6EvehUCVANFsz44w0yNwoQLIQc0xXF90p0cqmUNfvX8P16RCEVyr7e1sAIr5ETp53kv2Oh8Z1WKXhR21x26faDIPG3jQ+brHr6dhRbAYoCKY/H40Nla9RfFXC5D9RzRqpInOdLwva7WNJ8ogMryLt6Tg19PCOONI67On8Vp0qVs1kz7zECQ/QQNoNUzGV+72UXzZToxW8ecoSB5BmR0Ewm/FP4l4jRI51UMc9qKkjfjGipP2Y9qMB0rIR5aXiByMwI0D9it482rm2htHBQ/fo1H8=;5:lkR+QWrWkhHU8X9J8i71bxK5osVKPzVy+aN54Fh9k53p8SOiIkQfJ/O98Mt/XManzVfR6zPy2/e+v0JccMQyPnWdE5K1w739lrY/E3XhNhgLO8STQ7QM5j7tKvXo8DJWnAi6e/Hj1eyvP+k2B0g/O7iXpGDIfgXF+QNhSM4VuH0=;24:85wK7jN3gCRqleaZ9/Q75c/AP1/E39q9pvL4ASQgooYxhqv1gAsFvZjae02XSFZi0azllZNzSxJoYGJ4oE5ZkEzhUBoI4z9PSFXghnY+cRE=;7:BUc/89S04AupVwtiu+8+aJyfR56a0V0W7l2D72aToYMyR9vxi8ApIziccalSCXiJTECFxZPoykBLlKi4JLwDySfBbxSg+MSrsg/SGD79iyfLoX35eY9oWy9be8vjVQC6tdGsL/lA69kkrvRjC9ZYW4OpcaACn+hQdsc5uVfs2iNxAmmfrrDESIZ4Ef0zXL41e5UWJsJHzz+m66jZngt/JpOFzhlAAnKD44yxvHv80uaDAC5tUAnR5kz6x7E5G7IH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: softnautics.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2017 03:47:22.0303 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e84a96b6-28d3-4a4f-d234-08d53dee637c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 17b76cff-50c6-4f7a-9198-dd4afc5f8bea X-MS-Exchange-Transport-CrossTenantHeadersStamped: BM1PR0101MB1441 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3149 Lines: 102 Resolved all the missing a blank line after declarations checkpatch warnings. Issue found by checkpatch. Signed-off-by: Dhaval Shah --- drivers/misc/apds990x.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/misc/apds990x.c b/drivers/misc/apds990x.c index c9f07032c2fc..ed9412d750b7 100644 --- a/drivers/misc/apds990x.c +++ b/drivers/misc/apds990x.c @@ -715,6 +715,7 @@ static ssize_t apds990x_rate_avail(struct device *dev, { int i; int pos = 0; + for (i = 0; i < ARRAY_SIZE(arates_hz); i++) pos += sprintf(buf + pos, "%d ", arates_hz[i]); sprintf(buf + pos - 1, "\n"); @@ -725,6 +726,7 @@ static ssize_t apds990x_rate_show(struct device *dev, struct device_attribute *attr, char *buf) { struct apds990x_chip *chip = dev_get_drvdata(dev); + return sprintf(buf, "%d\n", chip->arate); } @@ -784,6 +786,7 @@ static ssize_t apds990x_prox_show(struct device *dev, { ssize_t ret; struct apds990x_chip *chip = dev_get_drvdata(dev); + if (pm_runtime_suspended(dev) || !chip->prox_en) return -EIO; @@ -807,6 +810,7 @@ static ssize_t apds990x_prox_enable_show(struct device *dev, struct device_attribute *attr, char *buf) { struct apds990x_chip *chip = dev_get_drvdata(dev); + return sprintf(buf, "%d\n", chip->prox_en); } @@ -847,6 +851,7 @@ static ssize_t apds990x_prox_reporting_mode_show(struct device *dev, struct device_attribute *attr, char *buf) { struct apds990x_chip *chip = dev_get_drvdata(dev); + return sprintf(buf, "%s\n", reporting_modes[!!chip->prox_continuous_mode]); } @@ -884,6 +889,7 @@ static ssize_t apds990x_lux_thresh_above_show(struct device *dev, struct device_attribute *attr, char *buf) { struct apds990x_chip *chip = dev_get_drvdata(dev); + return sprintf(buf, "%d\n", chip->lux_thres_hi); } @@ -891,6 +897,7 @@ static ssize_t apds990x_lux_thresh_below_show(struct device *dev, struct device_attribute *attr, char *buf) { struct apds990x_chip *chip = dev_get_drvdata(dev); + return sprintf(buf, "%d\n", chip->lux_thres_lo); } @@ -926,6 +933,7 @@ static ssize_t apds990x_lux_thresh_above_store(struct device *dev, { struct apds990x_chip *chip = dev_get_drvdata(dev); int ret = apds990x_set_lux_thresh(chip, &chip->lux_thres_hi, buf); + if (ret < 0) return ret; return len; @@ -937,6 +945,7 @@ static ssize_t apds990x_lux_thresh_below_store(struct device *dev, { struct apds990x_chip *chip = dev_get_drvdata(dev); int ret = apds990x_set_lux_thresh(chip, &chip->lux_thres_lo, buf); + if (ret < 0) return ret; return len; @@ -954,6 +963,7 @@ static ssize_t apds990x_prox_threshold_show(struct device *dev, struct device_attribute *attr, char *buf) { struct apds990x_chip *chip = dev_get_drvdata(dev); + return sprintf(buf, "%d\n", chip->prox_thres); } @@ -1026,6 +1036,7 @@ static ssize_t apds990x_chip_id_show(struct device *dev, struct device_attribute *attr, char *buf) { struct apds990x_chip *chip = dev_get_drvdata(dev); + return sprintf(buf, "%s %d\n", chip->chipname, chip->revision); } -- 2.11.0