Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752604AbdLHD4r (ORCPT <rfc822;w@1wt.eu>);
        Thu, 7 Dec 2017 22:56:47 -0500
Received: from imap1.codethink.co.uk ([176.9.8.82]:46462 "EHLO
        imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751809AbdLHD4q (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Dec 2017 22:56:46 -0500
Message-ID: <1512705400.18523.227.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 20/49] usbip: tools: Install all headers needed for
 libusbip development
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>,
        Shuah Khan <shuahkh@osg.samsung.com>,
        Sasha Levin <alexander.levin@verizon.com>
Date: Fri, 08 Dec 2017 03:56:40 +0000
In-Reply-To: <20171207124706.647290027@linuxfoundation.org>
References: <20171207124703.742654162@linuxfoundation.org>
         <20171207124706.647290027@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6-1+deb9u1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1605
Lines: 46

On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Ben Hutchings <ben@decadent.org.uk>
> 
> 
> [ Upstream commit c15562c0dcb2c7f26e891923b784cf1926b8c833 ]
> 
> usbip_host_driver.h now depends on several additional headers, which
> need to be installed along with it.
> 
> Fixes: 021aed845303 ("staging: usbip: userspace: migrate usbip_host_driver ...")
> Fixes: 3391ba0e2792 ("usbip: tools: Extract generic code to be shared with ...")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  tools/usb/usbip/Makefile.am |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- a/tools/usb/usbip/Makefile.am
> +++ b/tools/usb/usbip/Makefile.am
> @@ -1,6 +1,7 @@
>  SUBDIRS := libsrc src
>  includedir = @includedir@/usbip
>  include_HEADERS := $(addprefix libsrc/, \
> -		     usbip_common.h vhci_driver.h usbip_host_driver.h)
> +		     usbip_common.h vhci_driver.h usbip_host_driver.h \
> +		     list.h sysfs_utils.h usbip_host_common.h)

usbip_host_common.h was added in 4.7 (by the second commit listed
above), so for 4.4 and 3.18 it should not be added to this list.

Ben.

>  dist_man_MANS := $(addprefix doc/, usbip.8 usbipd.8)
> 
> 
> 
-- 
Ben Hutchings
Software Developer, Codethink Ltd.