Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751087AbdLHFKz (ORCPT ); Fri, 8 Dec 2017 00:10:55 -0500 Received: from imap1.codethink.co.uk ([176.9.8.82]:46860 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbdLHFKx (ORCPT ); Fri, 8 Dec 2017 00:10:53 -0500 Message-ID: <1512709849.18523.245.camel@codethink.co.uk> Subject: Re: [PATCH 4.4 38/49] xen-netfront: Improve error handling during initialization From: Ben Hutchings To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Ross Lagerwall , Boris Ostrovsky , "David S. Miller" , Sasha Levin Date: Fri, 08 Dec 2017 05:10:49 +0000 In-Reply-To: <20171207124709.059301507@linuxfoundation.org> References: <20171207124703.742654162@linuxfoundation.org> <20171207124709.059301507@linuxfoundation.org> Organization: Codethink Ltd. Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 869 Lines: 34 On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me > know. > > ------------------ > > From: Ross Lagerwall > > > [ Upstream commit e2e004acc7cbe3c531e752a270a74e95cde3ea48 ] [...] > @@ -1950,9 +1942,10 @@ abort_transaction_no_dev_fatal: >   xenbus_transaction_end(xbt, 1); >   destroy_ring: >   xennet_disconnect_backend(info); > - kfree(info->queues); > - info->queues = NULL; > + xennet_destroy_queues(info); >   out: > + unregister_netdev(info->netdev); > + xennet_free_netdev(info->netdev); >   return err; >  } This last bit of cleanup looks wrong. It was subsequently changed upstream by: 86b5672b1adb xen-netfront: avoid crashing on resume after a failure in talk_to_netback() Ben. -- Ben Hutchings Software Developer, Codethink Ltd.