Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751268AbdLHFcQ (ORCPT ); Fri, 8 Dec 2017 00:32:16 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:46630 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbdLHFcN (ORCPT ); Fri, 8 Dec 2017 00:32:13 -0500 X-Google-Smtp-Source: AGs4zMaOXxZP0kp7Yld1E2yfkKZxxLBKXNU4rfBXxcm+bBnGPLWbAuKldijk3p7V+bj+8kmtuv7TAKVTfgqgogvIXks= MIME-Version: 1.0 In-Reply-To: References: <1512673460-7865-1-git-send-email-jagan@amarulasolutions.com> <1512673460-7865-2-git-send-email-jagan@amarulasolutions.com> From: Jagan Teki Date: Fri, 8 Dec 2017 11:02:11 +0530 Message-ID: Subject: Re: [PATCH v2 2/3] arm64: allwinner: axp803: Add drivevbus regulator To: Chen-Yu Tsai Cc: Maxime Ripard , Icenowy Zheng , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi , Jagan Teki Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1252 Lines: 36 On Fri, Dec 8, 2017 at 8:22 AM, Chen-Yu Tsai wrote: > On Fri, Dec 8, 2017 at 3:04 AM, Jagan Teki wrote: >> Add reg_drivevbus regualtor for boards which are using >> external regulator to drive the OTG VBus through N_VBUSEN >> PMIC pin. >> >> Signed-off-by: Jagan Teki >> --- >> Changes for v2: >> - New patch >> >> arch/arm64/boot/dts/allwinner/axp803.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi b/arch/arm64/boot/dts/allwinner/axp803.dtsi >> index ff8af52..e5eae8b 100644 >> --- a/arch/arm64/boot/dts/allwinner/axp803.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/axp803.dtsi >> @@ -146,5 +146,10 @@ >> regulator-max-microvolt = <3000000>; >> regulator-name = "rtc-ldo"; >> }; >> + >> + reg_drivevbus: drivevbus { > > Could you keep the nodes in alphabetical order please? thought the same, but this seems to be different regulator from above AXP_DESC regulators and even binding documentation follow this order. thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India.