Date: Fri, 8 Dec 2017 08:37:18 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: jslaby@suse.com, patches@groups.riscv.org,
        linux-kernel@vger.kernel.org, Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH] tty: New RISC-V SBI console driver
Message-ID: <20171208073718.GA14027@kroah.com>
References: <20171208001015.27735-1-palmer@sifive.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171208001015.27735-1-palmer@sifive.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1946
Lines: 54

On Thu, Dec 07, 2017 at 04:10:15PM -0800, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmer@dabbelt.com>
> 
> The RISC-V ISA defines a simple console that is availiable via SBI calls
> on all systems.  This patch adds a driver for this console interface
> that can act as both a target for early printk and as the system
> console.  The core arch code already enables the early printk support
> when CONFIG_HVC_RISCV_SBI is defined.
> 
> There is one checkpatch.pl warning here: to check the MAINTAINERS file.
> They're all matched by the "K: riscv" line.
> 
> Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
> ---
>  arch/riscv/include/asm/hvc_riscv_sbi.h | 12 ++++++
>  drivers/tty/hvc/Kconfig                | 11 +++++
>  drivers/tty/hvc/Makefile               |  1 +
>  drivers/tty/hvc/hvc_riscv_sbi.c        | 75 ++++++++++++++++++++++++++++++++++
>  4 files changed, 99 insertions(+)
>  create mode 100644 arch/riscv/include/asm/hvc_riscv_sbi.h
>  create mode 100644 drivers/tty/hvc/hvc_riscv_sbi.c
> 
> diff --git a/arch/riscv/include/asm/hvc_riscv_sbi.h b/arch/riscv/include/asm/hvc_riscv_sbi.h
> new file mode 100644
> index 000000000000..41723ed7bd97
> --- /dev/null
> +++ b/arch/riscv/include/asm/hvc_riscv_sbi.h
> @@ -0,0 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +#ifndef _ASM_RISCV_HVC_RISCV_SBI_H
> +#define _ASM_RISCV_HVC_RISCV_SBI_H
> +
> +/*
> + * We always support CONFIG_EARLY_PRINTK via the SBI console driver because it
> + * works well enough that there's no penalty to doing so.
> + */
> +extern struct console riscv_sbi_early_console_dev __initdata;

Are you sure that __initdata should go into a .h file with an extern?

And why do you need this .h file?  Nothing in this patch uses it.

> +config HVC_RISCV_SBI
> +	bool "RISC-V SBI console support"
> +	depends on RISCV
> +	select HVC_DRIVER
> +	default y

Unless you can not boot your machine without this, you do not need 'y'.

thanks,

greg k-h