Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbdLHH5s (ORCPT ); Fri, 8 Dec 2017 02:57:48 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:55800 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbdLHH5q (ORCPT ); Fri, 8 Dec 2017 02:57:46 -0500 Date: Fri, 8 Dec 2017 08:57:35 +0100 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Icenowy Zheng , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Michael Trimarchi , "linux-arm-kernel@lists.infradead.org" , devicetree , "linux-kernel@vger.kernel.org" , linux-sunxi , Jagan Teki Subject: Re: [PATCH] arm64: allwinner: a64: orangepi-zero-plus2: add usb otg Message-ID: <20171208075735.nk5gsdpmbrol7fnq@flea.lan> References: <1512644748-14491-1-git-send-email-jagan@amarulasolutions.com> <20171207133409.cpp7wxx4yflkgavp@flea.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="km5sivfxzg2ekixt" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2675 Lines: 75 --km5sivfxzg2ekixt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 07, 2017 at 10:23:18PM +0530, Jagan Teki wrote: > On Thu, Dec 7, 2017 at 7:04 PM, Maxime Ripard > wrote: > > Hi, > > > > On Thu, Dec 07, 2017 at 04:35:48PM +0530, Jagan Teki wrote: > >> Add usb otg support for orangepi-zero-plus2 board: > >> - Add usb_otg node with dr_mode as 'otg' > >> - USB0-IDDET connected to PA21 > >> - VBUS connected through DCIN which always on > >> > >> Tested mass storage function. > >> > >> Signed-off-by: Jagan Teki > > > > Did you test the OTG or peripheral modes? >=20 > dr_mode with otg and I've tested mas storage gadget with mmc disk > emulation. So, peripheral, not OTG. > > > >> Note: Anyone please check vbus connection [1] > >> Since it is connected through DCIN of vcc-5v, I've added vcc-5v0 > >> regulator for the same and attached to usb0_vbus-supply but it is > >> disabling during kernel boot. > >> [ 1.887854] vcc5v0: disabling > > > > VBUS is the power line that is provided on the USB connector. In > > peripheral, that power is provided by the host, therefore it needs to > > be shutdown on the peripheral end. This is the expected behaviour. >=20 > So, in my test with 'otg' host drive the vbus so-it is disabling at > target end is it? You're not testing OTG, you're testing in peripheral mode. OTG is switching between host and peripheral at runtime. And I'm pretty sure this board cannot implement OTG at all, since its only source of power seems to be USB. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --km5sivfxzg2ekixt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAloqResACgkQ0rTAlCFN r3Rmng//bdtFaFXF6opR5C8rT8IL7nzmJ+3wyCeISXP0EfR90EMVFW0YAvRU4tvT X4R7tbAkaEvA27eWtwVeysYUsCD7jLFhBhOmDvvt56s2Pa7BXfzjljeT7990tKzR jLYq6VECvVKf+kFYQRM6sHswbLu36U9L9DmGY85b6OJOrl7vHKVHhB3s7xH3WsXS TDE3yd0rZJBx1uGELQGKGSuF0njof7I2Hg9Tz7p9eb4mxcoAKSPvA+T4L6SnL8PI OX3QDA/0oY+f6+o46hsDFT0UdWzhYFUj6Z458n50i6kJ7fBO9uY0BeW5lrEcNvUC Cobt2iO8wLmzEqs70Cu+SDc9HlybUncRh0kbA3BpbfDrNgQWW15I4Y+vPFsK3bLU guRVuTY1T7uuvJZed4hLfsPfcd8cTZWUfh+6UzuS+IcKN2beYlnvmsHJNxLG08XI dXFxpYEyyKFrWSdx0Ead6LxUw3KjEGCNbDKTbXm5fZzsUnUFvlO5//kVfaC4KM7G fpDLiYRTXjWzlS5K274jomWXiph/2Ja2JWEm1KrPf8ifGSzX0to7KvdlGLBgccMv rA8i890DMIuKQxQQ8ap92UihOG9N/4a0RYY7Dycnm8IF8bFo3dmF1ztR+b8MqU+Y LMgr1BeK9DZtObAGBko7Vtt0VRRZBugWesX+mrkSbXlkA1uk10U= =uxwI -----END PGP SIGNATURE----- --km5sivfxzg2ekixt--