Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753453AbdLHJnM (ORCPT ); Fri, 8 Dec 2017 04:43:12 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:60390 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753333AbdLHJkN (ORCPT ); Fri, 8 Dec 2017 04:40:13 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2BC9D60908 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=prsood@codeaurora.org Subject: Re: [PATCH] cgroup/cpuset: fix circular locking dependency To: Peter Zijlstra , Tejun Heo Cc: avagin@gmail.com, mingo@kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, sramana@codeaurora.org References: <1511868946-23959-1-git-send-email-prsood@codeaurora.org> <623f214b-8b9a-f967-7a3d-ca9c06151267@codeaurora.org> <20171204202219.GF2421075@devbig577.frc2.facebook.com> <20171204225825.GP2421075@devbig577.frc2.facebook.com> <20171204230117.GF20227@worktop.programming.kicks-ass.net> From: Prateek Sood Message-ID: <4e63b5e9-1696-910f-16ac-4d4d7eb98725@codeaurora.org> Date: Fri, 8 Dec 2017 15:10:05 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171204230117.GF20227@worktop.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1348 Lines: 36 On 12/05/2017 04:31 AM, Peter Zijlstra wrote: > On Mon, Dec 04, 2017 at 02:58:25PM -0800, Tejun Heo wrote: >> Hello, again. >> >> On Mon, Dec 04, 2017 at 12:22:19PM -0800, Tejun Heo wrote: >>> Hello, >>> >>> On Mon, Dec 04, 2017 at 10:44:49AM +0530, Prateek Sood wrote: >>>> Any feedback/suggestion for this patch? >>> >>> Sorry about the delay. I'm a bit worried because it feels like we're >>> chasing a squirrel. I'll think through the recent changes and this >>> one and get back to you. >> >> Can you please take a look at the following pending commit? >> >> https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git/commit/?h=for-4.15-fixes&id=e8b3f8db7aad99fcc5234fc5b89984ff6620de3d >> >> AFAICS, this should remove the circular dependency you originally >> reported. I'll revert the two cpuset commits for now. > > So I liked his patches in that we would be able to go back to > synchronous sched_domain building. > https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git/commit/?h=for-4.15-fixes&id=e8b3f8db7aad99fcc5234fc5b89984ff6620de3d This will fix the original circular locking dependency issue. I will let you both (Peter & TJ) to decide on which one to pick. -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project