Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753347AbdLHKdc (ORCPT ); Fri, 8 Dec 2017 05:33:32 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:44146 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752956AbdLHKdV (ORCPT ); Fri, 8 Dec 2017 05:33:21 -0500 X-Google-Smtp-Source: AGs4zMa9y+H1TPmjdR9rPOuXgsBcbXHa7l2LdMkAUASzkUcdXQwtHRx4XjWQfe32tRGL/LKdWuHGNw== Date: Fri, 8 Dec 2017 19:33:15 +0900 From: Sergey Senozhatsky To: "Liu, Changcheng" Cc: sergey.senozhatsky@gmail.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell Message-ID: <20171208103315.GF628@jagdpanzerIV> References: <20171208093751.GA175471@sofia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171208093751.GA175471@sofia> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 667 Lines: 27 On (12/08/17 17:37), Liu, Changcheng wrote: > > On some linux distributions, the default link of sh > is dash which deoesn't support split array like > ${var//,/ } > It's better to force to use bash shell directly. > > Signed-off-by: Liu Changcheng Reviewed-by: Sergey Senozhatsky -ss > diff --git a/tools/vm/slabinfo-gnuplot.sh b/tools/vm/slabinfo-gnuplot.sh > index 35b0398..0cf28aa 100644 > --- a/tools/vm/slabinfo-gnuplot.sh > +++ b/tools/vm/slabinfo-gnuplot.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > > # Sergey Senozhatsky, 2015 > # sergey.senozhatsky.work@gmail.com > -- > 2.7.4 >