Date: Fri, 8 Dec 2017 12:33:38 +0100
From: Olaf Hering <olaf@aepfle.de>
To: Eduardo Otubo <otubo@redhat.com>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
        sthemmin@microsoft.com, haiyangz@microsoft.com, kys@microsoft.com,
        vkuznets@redhat.com, mgamal@redhat.com, cavery@redhat.com
Subject: Re: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before
 setting ip
Message-ID: <20171208113338.GA3134@aepfle.de>
References: <20171208102056.4725-1-otubo@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="/04w6evG8XlLl3ft"
Content-Disposition: inline
In-Reply-To: <20171208102056.4725-1-otubo@redhat.com>
User-Agent: Mutt/1.9.1 (7184)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1101
Lines: 36


--/04w6evG8XlLl3ft
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

On Fri, Dec 08, Eduardo Otubo wrote:

>  tools/hv/hv_set_ifconfig.sh | 45 +++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 43 insertions(+), 2 deletions(-)

> +        # let's wait for 3 minutes

Was this codepath runtime tested?

Last time this came up, the conclusion was that Windows terminates the
"KVP connection" after 60 seconds. After that, the VM must be rebooted
because the kernel does not deal with the long-running script. It is
also not clear what the kernel is supposed to do: either silently report
success and hope the scripts reports success one day, or report error
independent from what the script actually returns. New KVP requests
would need to be queued either way.


Olaf

--/04w6evG8XlLl3ft
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCWip4kgAKCRBdQqD6ppg2
fldoAKCtMhqhDjqqYOzo6Bwa2V6BWey8OACfaxZNcYYo9Eq5RiLLLkGcOJqiM4o=
=B2yr
-----END PGP SIGNATURE-----

--/04w6evG8XlLl3ft--