MIME-Version: 1.0
In-Reply-To: <7131f15434d17eb64a83999bff9e96a7e9d4b5f5.1512723245.git.green.hu@gmail.com>
References: <cover.1512723245.git.green.hu@gmail.com> <7131f15434d17eb64a83999bff9e96a7e9d4b5f5.1512723245.git.green.hu@gmail.com>
From: Philippe Ombredanne <pombredanne@nexb.com>
Date: Fri, 8 Dec 2017 14:19:06 +0100
Message-ID: <CAOFm3uF5BpxpAAH4eq-OSY1bS2cSGS27NY524JoAMzJ1F4bbrA@mail.gmail.com>
Subject: Re: [PATCH v3 04/33] nds32: Kernel booting and initialization
To: Greentime Hu <green.hu@gmail.com>
Cc: greentime@andestech.com, LKML <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, linux-arch@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, jason@lakedaemon.net,
        marc.zyngier@arm.com, Rob Herring <robh+dt@kernel.org>,
        netdev@vger.kernel.org, deanbo422@gmail.com,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        viro@zeniv.linux.org.uk, dhowells@redhat.com,
        Will Deacon <will.deacon@arm.com>, daniel.lezcano@linaro.org,
        linux-serial@vger.kernel.org, geert.uytterhoeven@gmail.com,
        linus.walleij@linaro.org, Mark Rutland <mark.rutland@arm.com>,
        greg@kroah.com, Vincent Chen <vincentc@andestech.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1627
Lines: 46

Dear Greentime,

On Fri, Dec 8, 2017 at 10:11 AM, Greentime Hu <green.hu@gmail.com> wrote:
> From: Greentime Hu <greentime@andestech.com>
>
> This patch includes the kernel startup code. It can get dtb pointer
> passed from bootloader. It will create a temp mapping by tlb
> instructions at beginning and goto start_kernel.
>
> Signed-off-by: Vincent Chen <vincentc@andestech.com>
> Signed-off-by: Greentime Hu <greentime@andestech.com>
[]
> --- /dev/null
> +++ b/arch/nds32/kernel/head.S
> @@ -0,0 +1,202 @@
> +/*
> + * Copyright (C) 2005-2017 Andes Technology Corporation
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */


Have you considered using the new SPDX ids instead of this fine legalese?
e.g.:

// SPDX-License-Identifier: GPL-2.0
// Copyright (C) 2005-2017 Andes Technology Corporation

This is much shorter and neater (unless you are a legalese lover of course!)

Check also Thomas doc patches and Linus comments on why he prefers the
C++ comment style for these.

-- 
Cordially
Philippe Ombredanne, your friendly licensing scruffy bot