Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753410AbdLHN0Y (ORCPT ); Fri, 8 Dec 2017 08:26:24 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:38383 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752883AbdLHN0V (ORCPT ); Fri, 8 Dec 2017 08:26:21 -0500 X-Google-Smtp-Source: ACJfBotp5tjyGGbgpXFWkZhEF0cVFpclh8auOEjIft+9ikRgBqR00b5gMFJfVzAyqBMCgoCLxZqJy7Sfp2FN3sbD4g0= MIME-Version: 1.0 In-Reply-To: <1512724105-1778-3-git-send-email-smitha.t@samsung.com> References: <1512724105-1778-1-git-send-email-smitha.t@samsung.com> <1512724105-1778-3-git-send-email-smitha.t@samsung.com> From: Philippe Ombredanne Date: Fri, 8 Dec 2017 14:25:39 +0100 Message-ID: Subject: Re: [Patch v6 02/12] [media] s5p-mfc: Adding initial support for MFC v10.10 To: Smitha T Murthy Cc: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Linux Media Mailing List , LKML , kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com, a.hajda@samsung.com, Mauro Carvalho Chehab , pankaj.dubey@samsung.com, krzk@kernel.org, m.szyprowski@samsung.com, s.nawrocki@samsung.com, Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1836 Lines: 50 Smitha, On Fri, Dec 8, 2017 at 10:08 AM, Smitha T Murthy wrote: > Adding the support for MFC v10.10, with new register file and > necessary hw control, decoder, encoder and structural changes. > > CC: Rob Herring > CC: devicetree@vger.kernel.org > Signed-off-by: Smitha T Murthy > Reviewed-by: Andrzej Hajda > Acked-by: Rob Herring [] > --- /dev/null > +++ b/drivers/media/platform/s5p-mfc/regs-mfc-v10.h > @@ -0,0 +1,36 @@ > +/* > + * Register definition file for Samsung MFC V10.x Interface (FIMV) driver > + * > + * Copyright (c) 2017 Samsung Electronics Co., Ltd. > + * http://www.samsung.com/ > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ Have you considered using the new SPDX ids instead of this fine legalese? e.g.: // SPDX-License-Identifier: GPL-2.0 This is much shorter and neater (unless you are a legalese lover of course!) Check also Thomas doc patches and Linus comments on why he prefers the C++ comment style for these. And even better could be this more compact form? I am a big fan of the C++ style comments for these (and so is Linus) // SPDX-License-Identifier: GPL-2.0 // Copyright (c) 2017 Samsung Electronics Co., Ltd. // Register definition file for Samsung MFC V10.x Interface (FIMV) driver You can also read this fine article from a fellow Samsung colleague [1]. And if you ever consider doing this for all Samsung's past, present and future contributions, you will have my deep gratitude [1] https://blogs.s-osg.org/linux-kernel-license-practices-revisited-spdx/ -- Cordially Philippe Ombredanne, your licensing helper elf