Date: Fri, 8 Dec 2017 14:43:08 +0100
From: Eduardo Otubo <otubo@redhat.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
        sthemmin@microsoft.com, haiyangz@microsoft.com, kys@microsoft.com,
        vkuznets@redhat.com, mgamal@redhat.com, cavery@redhat.com
Subject: Re: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before
 setting ip
Message-ID: <20171208134308.GA29516@vader>
References: <20171208102056.4725-1-otubo@redhat.com>
 <20171208113338.GA3134@aepfle.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20171208113338.GA3134@aepfle.de>
User-Agent: Mutt/1.8.3+47 (5f034395e53d) (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1043
Lines: 23

On Fri, Dec 08, 2017 at 12:33:38PM +0100, Olaf Hering wrote:
> On Fri, Dec 08, Eduardo Otubo wrote:
> 
> >  tools/hv/hv_set_ifconfig.sh | 45 +++++++++++++++++++++++++++++++++++++++++++--
> >  1 file changed, 43 insertions(+), 2 deletions(-)
> 
> > +        # let's wait for 3 minutes
> 
> Was this codepath runtime tested?
> 
> Last time this came up, the conclusion was that Windows terminates the
> "KVP connection" after 60 seconds. After that, the VM must be rebooted
> because the kernel does not deal with the long-running script. It is
> also not clear what the kernel is supposed to do: either silently report
> success and hope the scripts reports success one day, or report error
> independent from what the script actually returns. New KVP requests
> would need to be queued either way.
> 
Now that you mentioned, I guess my tests never touched this part. But I guess
we're going to fix this downstream-only setting a rule on systemd to start
hypervkvpd only after NetworkManager started. Please drop the reviews on this.

Regards,