From: "Liang, Kan" <kan.liang@intel.com>
To: "'acme@kernel.org'" <acme@kernel.org>,
        "'peterz@infradead.org'" <peterz@infradead.org>,
        "'mingo@redhat.com'" <mingo@redhat.com>,
        "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
CC: "'jolsa@kernel.org'" <jolsa@kernel.org>,
        "'eranian@google.com'" <eranian@google.com>,
        "'ak@linux.intel.com'" <ak@linux.intel.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>
Subject: RE: [PATCH V2] perf script: add script to profile and resolve
 physical mem type
Thread-Topic: [PATCH V2] perf script: add script to profile and resolve
 physical mem type
Thread-Index: AQHTTd4TIJZdwMdEMU6VrilGLG4DTqMoo56ggBEoDXA=
Date: Fri, 8 Dec 2017 14:52:27 +0000
Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077537F2DE7@SHSMSX103.ccr.corp.intel.com>
References: <1508969363-351481-1-git-send-email-kan.liang@intel.com>
 <37D7C6CF3E00A74B8858931C1DB2F077537EB76B@SHSMSX103.ccr.corp.intel.com>
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077537EB76B@SHSMSX103.ccr.corp.intel.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 7476
Lines: 217

Hi Arnaldo,

Ping.
Any comments for the script?

Thanks,
Kan

> >
> > From: Kan Liang <Kan.liang@intel.com>
> >
> > There could be different types of memory in the system. E.g normal
> > System Memory, Persistent Memory. To understand how the workload
> maps
> > to those memories, it's important to know the I/O statistics of them.
> > Perf can collect physical addresses, but those are raw data.
> > It still needs extra work to resolve the physical addresses.
> > Provide a script to facilitate the physical addresses resolving and
> > I/O statistics.
> >
> > Profile with MEM_INST_RETIRED.ALL_LOADS or
> MEM_UOPS_RETIRED.ALL_LOADS
> > event if any of them is available.
> > Look up the /proc/iomem and resolve the physical address.
> > Provide memory type summary.
> >
> > Here is an example output.
> >  #perf script report mem-phys-addr
> > Event: mem_inst_retired.all_loads:P
> > Memory type                                    count   percentage
> > ----------------------------------------  -----------  -----------
> > System RAM                                        74        53.2%
> > Persistent Memory                                 55        39.6%
> > N/A                                               10         7.2%
> >
> > Signed-off-by: Kan Liang <Kan.liang@intel.com>
> > ---
> >
> > Changes since V1:
> >  - Do not mix DLA and Load Latency. Do not compare the loads and stores.
> >    Only profile the loads.
> >  - Use event name to replace the RAW event
> >
> >  tools/perf/scripts/python/bin/mem-phys-addr-record | 19 +++++
> > tools/perf/scripts/python/bin/mem-phys-addr-report |  3 +
> >  tools/perf/scripts/python/mem-phys-addr.py         | 97
> > ++++++++++++++++++++++
> >  .../util/scripting-engines/trace-event-python.c    |  2 +
> >  4 files changed, 121 insertions(+)
> >  create mode 100644 tools/perf/scripts/python/bin/mem-phys-addr-
> record
> >  create mode 100644 tools/perf/scripts/python/bin/mem-phys-addr-report
> >  create mode 100644 tools/perf/scripts/python/mem-phys-addr.py
> >
> > diff --git a/tools/perf/scripts/python/bin/mem-phys-addr-record
> > b/tools/perf/scripts/python/bin/mem-phys-addr-record
> > new file mode 100644
> > index 0000000..5a87512
> > --- /dev/null
> > +++ b/tools/perf/scripts/python/bin/mem-phys-addr-record
> > @@ -0,0 +1,19 @@
> > +#!/bin/bash
> > +
> > +#
> > +# Profiling physical memory by all retired load instructions/uops
> > +event # MEM_INST_RETIRED.ALL_LOADS or
> MEM_UOPS_RETIRED.ALL_LOADS #
> > +
> > +load=`perf list | grep mem_inst_retired.all_loads` if [ -z "$load" ];
> > +then
> > +	load=`perf list | grep mem_uops_retired.all_loads` fi if [ -z
> > +"$load" ]; then
> > +	echo "There is no event to count all retired load instructions/uops."
> > +	exit 1
> > +fi
> > +
> > +arg=$(echo $load | tr -d ' ')
> > +arg="$arg:P"
> > +perf record --phys-data -e $arg $@
> > diff --git a/tools/perf/scripts/python/bin/mem-phys-addr-report
> > b/tools/perf/scripts/python/bin/mem-phys-addr-report
> > new file mode 100644
> > index 0000000..3f2b847
> > --- /dev/null
> > +++ b/tools/perf/scripts/python/bin/mem-phys-addr-report
> > @@ -0,0 +1,3 @@
> > +#!/bin/bash
> > +# description: resolve physical address samples perf script $@ -s
> > +"$PERF_EXEC_PATH"/scripts/python/mem-phys-addr.py
> > diff --git a/tools/perf/scripts/python/mem-phys-addr.py
> > b/tools/perf/scripts/python/mem-phys-addr.py
> > new file mode 100644
> > index 0000000..1d1f757
> > --- /dev/null
> > +++ b/tools/perf/scripts/python/mem-phys-addr.py
> > @@ -0,0 +1,97 @@
> > +# mem-phys-addr.py: Resolve physical address samples # Copyright (c)
> > +2017, Intel Corporation.
> > +#
> > +# This program is free software; you can redistribute it and/or
> > +modify it # under the terms and conditions of the GNU General Public
> > +License, # version 2, as published by the Free Software Foundation.
> > +#
> > +# This program is distributed in the hope it will be useful, but
> > +WITHOUT # ANY WARRANTY; without even the implied warranty of
> > MERCHANTABILITY or
> > +# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
> > +License
> > for
> > +# more details.
> > +
> > +from __future__ import division
> > +import os
> > +import sys
> > +import struct
> > +import re
> > +import bisect
> > +import collections
> > +
> > +sys.path.append(os.environ['PERF_EXEC_PATH'] + \
> > +	'/scripts/python/Perf-Trace-Util/lib/Perf/Trace')
> > +
> > +system_ram = []
> > +pmem = []
> > +f = None
> > +load_mem_type_cnt = collections.Counter() event_name = None
> > +
> > +def parse_iomem():
> > +	global f
> > +	f = open('/proc/iomem', 'r')
> > +	for i, j in enumerate(f):
> > +		m = re.split('-|:',j,2)
> > +		if m[2].strip() == 'System RAM':
> > +			system_ram.append(long(m[0], 16))
> > +			system_ram.append(long(m[1], 16))
> > +		if m[2].strip() == 'Persistent Memory':
> > +			pmem.append(long(m[0], 16))
> > +			pmem.append(long(m[1], 16))
> > +
> > +def print_memory_type():
> > +	print "Event: %s" % (event_name)
> > +	print "%-40s  %10s  %10s\n" % ("Memory type", "count",
> > "percentage"),
> > +	print "%-40s  %10s  %10s\n" % ("----------------------------------------", \
> > +					"-----------", "-----------"),
> > +	total = sum(load_mem_type_cnt.values())
> > +	for mem_type, count in sorted(load_mem_type_cnt.most_common(),
> > \
> > +					key = lambda(k, v): (v, k), reverse =
> > True):
> > +		print "%-40s  %10d  %10.1f%%\n" % (mem_type, count, 100 *
> > count / total),
> > +
> > +def trace_begin():
> > +	parse_iomem()
> > +
> > +def trace_end():
> > +	print_memory_type()
> > +	f.close()
> > +
> > +def is_system_ram(phys_addr):
> > +	#/proc/iomem is sorted
> > +	position = bisect.bisect(system_ram, phys_addr)
> > +	if position % 2 == 0:
> > +		return False
> > +	return True
> > +
> > +def is_persistent_mem(phys_addr):
> > +	position = bisect.bisect(pmem, phys_addr)
> > +	if position % 2 == 0:
> > +		return False
> > +	return True
> > +
> > +def find_memory_type(phys_addr):
> > +	if phys_addr == 0:
> > +		return "N/A"
> > +	if is_system_ram(phys_addr):
> > +		return "System RAM"
> > +
> > +	if is_persistent_mem(phys_addr):
> > +		return "Persistent Memory"
> > +
> > +	#slow path, search all
> > +	f.seek(0, 0)
> > +	for j in f:
> > +		m = re.split('-|:',j,2)
> > +		if long(m[0], 16) <= phys_addr <= long(m[1], 16):
> > +			return m[2]
> > +	return "N/A"
> > +
> > +def process_event(param_dict):
> > +	name       = param_dict["ev_name"]
> > +	sample     = param_dict["sample"]
> > +	phys_addr  = sample["phys_addr"]
> > +
> > +	global event_name
> > +	if event_name == None:
> > +		event_name = name
> > +	load_mem_type_cnt[find_memory_type(phys_addr)] += 1
> > diff --git a/tools/perf/util/scripting-engines/trace-event-python.c
> > b/tools/perf/util/scripting-engines/trace-event-python.c
> > index c7187f0..8cd6317 100644
> > --- a/tools/perf/util/scripting-engines/trace-event-python.c
> > +++ b/tools/perf/util/scripting-engines/trace-event-python.c
> > @@ -500,6 +500,8 @@ static PyObject *get_perf_sample_dict(struct
> > perf_sample *sample,
> >  			PyLong_FromUnsignedLongLong(sample->time));
> >  	pydict_set_item_string_decref(dict_sample, "period",
> >  			PyLong_FromUnsignedLongLong(sample->period));
> > +	pydict_set_item_string_decref(dict_sample, "phys_addr",
> > +			PyLong_FromUnsignedLongLong(sample-
> > >phys_addr));
> >  	set_sample_read_in_dict(dict_sample, sample, evsel);
> >  	pydict_set_item_string_decref(dict, "sample", dict_sample);
> >
> > --
> > 2.7.4