Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270788AbTGNUdL (ORCPT ); Mon, 14 Jul 2003 16:33:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270807AbTGNU1j (ORCPT ); Mon, 14 Jul 2003 16:27:39 -0400 Received: from twilight.ucw.cz ([81.30.235.3]:7146 "EHLO twilight.ucw.cz") by vger.kernel.org with ESMTP id S270833AbTGNU1S (ORCPT ); Mon, 14 Jul 2003 16:27:18 -0400 Date: Mon, 14 Jul 2003 22:41:43 +0200 From: Vojtech Pavlik To: Pavel Machek Cc: Vojtech Pavlik , Nigel Cunningham , Jamie Lokier , Dmitry Torokhov , swsusp-devel , Linux Kernel Mailing List Subject: Re: [Swsusp-devel] Re: Thoughts wanted on merging Software Suspend enhancements Message-ID: <20030714204143.GA25731@ucw.cz> References: <20030712140057.GC284@elf.ucw.cz> <200307121734.29941.dtor_core@ameritech.net> <20030712225143.GA1508@elf.ucw.cz> <20030713133517.GD19132@mail.jlokier.co.uk> <20030713193114.GD570@elf.ucw.cz> <1058130071.1829.2.camel@laptop-linux> <20030713210934.GK570@elf.ucw.cz> <1058147684.2400.9.camel@laptop-linux> <20030714201245.GC24964@ucw.cz> <20030714201804.GF902@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030714201804.GF902@elf.ucw.cz> User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1184 Lines: 29 On Mon, Jul 14, 2003 at 10:18:04PM +0200, Pavel Machek wrote: > Hi! > > > > Having listened to the arguments, I'll make pressing Escape to cancel > > > the suspend a feature which defaults to being disabled and can be > > > enabled via a proc entry in 2.4. I won't add code to poll for ACPI (or > > > APM) events :> > > > > I'd suggest making it a mappable function in the keymap, like reboot is > > for example. Both for initiating and stopping the suspend. How about > > that? > > Any user can load his own keymap, I believe... And I do not like > having special /proc options for esc key... So what? He can press ctrl-alt-del or whatever if he has access to the keyboard anyway. Nevertheless I don't see any way to cause harm by cancelling a sw-suspend other than if a server was shutting down due to the UPS batteries being empty. And in that case the machine will be in a locked room anyway. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/