Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754469AbdLHQEC (ORCPT ); Fri, 8 Dec 2017 11:04:02 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:55144 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754040AbdLHQEB (ORCPT ); Fri, 8 Dec 2017 11:04:01 -0500 Date: Fri, 08 Dec 2017 11:03:59 -0500 (EST) Message-Id: <20171208.110359.272239843105611340.davem@davemloft.net> To: marcelo.leitner@gmail.com Cc: laoar.shao@gmail.com, songliubraving@fb.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, rostedt@goodmis.org, bgregg@netflix.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 net-next] net/tcp: trace all TCP/IP state transition with tcp_set_state tracepoint From: David Miller In-Reply-To: <20171208110356.GS13341@localhost.localdomain> References: <20171208110356.GS13341@localhost.localdomain> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 08 Dec 2017 08:04:01 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 280 Lines: 8 From: Marcelo Ricardo Leitner Date: Fri, 8 Dec 2017 09:03:56 -0200 > I'm okay with this v5 then, can't see a better way around it. I would suggest not making this a TCP specific feature. Because socket state changes are not a TCP specific behavior.