Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752628AbdLHSk4 (ORCPT ); Fri, 8 Dec 2017 13:40:56 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:32866 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751268AbdLHSkz (ORCPT ); Fri, 8 Dec 2017 13:40:55 -0500 Date: Fri, 8 Dec 2017 19:40:46 +0100 From: Peter Zijlstra To: LKML , DRI Development , Intel Graphics Development , Tvrtko Ursulin , Marta Lofstedt , Byungchul Park , Ingo Molnar , Tejun Heo , Kees Cook , Thomas Gleixner , Shaohua Li , Andrew Morton , Jens Axboe , Greg Kroah-Hartman , Jonathan Corbet , Oleg Nesterov , Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion Message-ID: <20171208184046.oz6x5dg3zqr37icc@hirez.programming.kicks-ass.net> References: <20171207100849.407-1-daniel.vetter@ffwll.ch> <20171207122255.zi5ishny24k66ik7@hirez.programming.kicks-ass.net> <20171207145828.z52kjbrrlcl75m7m@phenom.ffwll.local> <20171207195709.cxcil57boc6czdot@hirez.programming.kicks-ass.net> <20171207205657.wkt6xj3e2opegqeq@phenom.ffwll.local> <20171208101416.hu4uwan3jgcbb6dw@hirez.programming.kicks-ass.net> <20171208163628.juefyg3x32umj7um@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171208163628.juefyg3x32umj7um@phenom.ffwll.local> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 401 Lines: 9 On Fri, Dec 08, 2017 at 05:36:28PM +0100, Daniel Vetter wrote: > Aside: Could/should we take some fake lockdep locks around these > callbacks, since not all drivers call them from a hardirq context? Just to > validate that everyone follows the contract. What I typically do is use local_irq_save/restore over the actual callback. Then if someone doesn't honour the contract, it shows real quick :-)