Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752628AbdLHTEb (ORCPT ); Fri, 8 Dec 2017 14:04:31 -0500 Received: from mail-cys01nam02on0105.outbound.protection.outlook.com ([104.47.37.105]:47264 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751268AbdLHTEa (ORCPT ); Fri, 8 Dec 2017 14:04:30 -0500 From: KY Srinivasan To: Olaf Hering , Eduardo Otubo CC: "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "Stephen Hemminger" , Haiyang Zhang , "vkuznets@redhat.com" , "mgamal@redhat.com" , "cavery@redhat.com" Subject: RE: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip Thread-Topic: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip Thread-Index: AQHTcA5Ey0iLBzhAx0OknmbLEbe4YKM5UKsAgAB9uqA= Date: Fri, 8 Dec 2017 19:04:26 +0000 Message-ID: References: <20171208102056.4725-1-otubo@redhat.com> <20171208113338.GA3134@aepfle.de> In-Reply-To: <20171208113338.GA3134@aepfle.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=kys@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-12-08T19:04:24.3431884Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2601:600:a280:b50:c6c:96a0:caf8:cd8b] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR21MB0634;6:F0B3b/qb0RmXOqiu+AeJub/tmZhngitQsH7HGisoHn8qjw8Osac66wBHTUCQkBSaFQuLcG2et7IU3eEqp80HukfhgtYRubRDAE5V+XnDja4R1kFyEKhHxubVqP/UKT2KtBWe9PV9XVwF5zmAc3m8RoRFljc/zTvTNUwx0c0AiEr0MGjrjIuyGCpFCiI8Jqlho+nVYeVfj3LfWZwOIjRc09bO566H3j43Gb9rDf0dAlCINe93JDeJp4a7JPYhhsKNMAai4/VcgyCFn7Zr5x4+408LjaGfWF8/zFkXbQ/dAXjiNgbw3sj2J0pvt1CD8mMrxi0HUwxEAjnuPLN29WKl3uEn4mz2HgIzuYSlVOZW0dc=;5:S0BF+3zLYiaOxjY24brCOw11zFZaKoBhtw12i1BaOmoQyO/b1nqsXFrB1BuqPzi790DDOPrv8sk9YjiT6iCzJ4wHoBE9jket5m5lvCa38Afr96mRMbIxiVGYxBFabq0xwzmJ94wtvOCe8X8yftzbOT+1KASSTAhB92MH8amBzKQ=;24:nxNFvq1ucIuOYSmrVlW/pFhxQgCdAt4DeyBJPsUN1BXuc7dDQH+9B5WBR9WGA16ikbeOYfSsdMtZ6yVgG7/cx/Oq8DJL9JW2oKI3gLc8db0=;7:UXJ/FICxkm9vA8b68Q/P7UDexv7qOfnJJLspMCkkFadYYw9dutateb7cnOn8MxVldxo+AzyPlr7NKQhbu2G0xkxgYpMXav2MeKrXyQFtkA/pjBnd50Mho8uvAJGXJT9X36OhJKxyOw64DtLBfBQ+QxAO5UmeHT1JWWU7cihvFufRKMqY0RURojp7LnL6+udtPBmrAKH0mmJmzYYW1er1nI6osPCb68aZGu1o4f7GePHqNTNWOqNYiViW4OQtGfVY x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10019020)(346002)(39860400002)(366004)(376002)(24454002)(13464003)(199004)(189003)(2950100002)(54906003)(53546010)(5660300001)(106356001)(8990500004)(53936002)(305945005)(7736002)(74316002)(4326008)(86362001)(105586002)(8936002)(22452003)(97736004)(76176011)(86612001)(110136005)(7696005)(25786009)(316002)(10090500001)(68736007)(14454004)(3280700002)(2906002)(102836003)(6116002)(2900100001)(6506006)(229853002)(33656002)(6246003)(478600001)(8676002)(81166006)(9686003)(77096006)(81156014)(3660700001)(10290500003)(6436002)(55016002)(99286004);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR21MB0634;H:DM5PR21MB0476.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: da685afe-696e-472f-d546-08d53e6e8086 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307);SRVR:DM5PR21MB0634; x-ms-traffictypediagnostic: DM5PR21MB0634: authentication-results: spf=none (sender IP is ) smtp.mailfrom=kys@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(20558992708506)(89211679590171)(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040450)(2401047)(5005006)(8121501046)(3231022)(93006095)(93001095)(10201501046)(3002001)(6055026)(61426038)(61427038)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123564025)(20161123558100)(20161123555025)(6072148)(201708071742011);SRVR:DM5PR21MB0634;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DM5PR21MB0634; x-forefront-prvs: 0515208626 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: da685afe-696e-472f-d546-08d53e6e8086 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2017 19:04:26.4719 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR21MB0634 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB8J4bwx021623 Content-Length: 1321 Lines: 37 > -----Original Message----- > From: Olaf Hering [mailto:olaf@aepfle.de] > Sent: Friday, December 8, 2017 3:34 AM > To: Eduardo Otubo > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; Stephen > Hemminger ; Haiyang Zhang > ; KY Srinivasan ; > vkuznets@redhat.com; mgamal@redhat.com; cavery@redhat.com > Subject: Re: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before > setting ip > > On Fri, Dec 08, Eduardo Otubo wrote: > > > tools/hv/hv_set_ifconfig.sh | 45 > +++++++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 43 insertions(+), 2 deletions(-) > > > + # let's wait for 3 minutes > > Was this codepath runtime tested? > > Last time this came up, the conclusion was that Windows terminates the > "KVP connection" after 60 seconds. After that, the VM must be rebooted > because the kernel does not deal with the long-running script. It is > also not clear what the kernel is supposed to do: either silently report > success and hope the scripts reports success one day, or report error > independent from what the script actually returns. New KVP requests > would need to be queued either way. Agreed; 180 seconds is more than what the host is willing to wait. K. Y > > > Olaf