Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753136AbdLHTId (ORCPT ); Fri, 8 Dec 2017 14:08:33 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:57500 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752521AbdLHTIc (ORCPT ); Fri, 8 Dec 2017 14:08:32 -0500 Date: Fri, 08 Dec 2017 14:08:30 -0500 (EST) Message-Id: <20171208.140830.1542476063382857622.davem@davemloft.net> To: michael.chan@broadcom.com Cc: calvinowens@fb.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] bnxt_en: Fix sources of spurious netpoll warnings From: David Miller In-Reply-To: References: <1d2d29c336343cc590c8ba31156511381c39fc84.1512511928.git.calvinowens@fb.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 08 Dec 2017 11:08:31 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 18 From: Michael Chan Date: Fri, 8 Dec 2017 09:35:42 -0800 > On Fri, Dec 8, 2017 at 9:05 AM, Calvin Owens wrote: >> After applying 2270bc5da3497945 ("bnxt_en: Fix netpoll handling") and >> 903649e718f80da2 ("bnxt_en: Improve -ENOMEM logic in NAPI poll loop."), >> we still see the following WARN fire: ... >> This happens because we increment rx_pkts on -ENOMEM and -EIO, resulting >> in rx_pkts > 0. Fix this by only bumping rx_pkts if we were actually >> given a non-zero budget. >> >> Signed-off-by: Calvin Owens > > Thanks. > Acked-by: Michael Chan Applied and queued up for -stable.