Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753410AbdLHVNV (ORCPT <rfc822;w@1wt.eu>);
        Fri, 8 Dec 2017 16:13:21 -0500
Received: from mga09.intel.com ([134.134.136.24]:16638 "EHLO mga09.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752289AbdLHVNR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 8 Dec 2017 16:13:17 -0500
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,379,1508828400"; 
   d="scan'208";a="1307195"
From: "Moore, Robert" <robert.moore@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
        Vasyl Gomonovych <gomonovych@gmail.com>
CC: "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        "devel@acpica.org" <devel@acpica.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Schmauss, Erik" <erik.schmauss@intel.com>
Subject: RE: [PATCH] ACPICA: Fix indentation
Thread-Topic: [PATCH] ACPICA: Fix indentation
Thread-Index: AQHTcEG4LfHtaoyqS0OOgcnQhgtWXKM6M1OA//+861A=
Date: Fri, 8 Dec 2017 21:13:15 +0000
Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E3B74FA783@ORSMSX110.amr.corp.intel.com>
References: <1512750553-15467-1-git-send-email-gomonovych@gmail.com>
 <CAJZ5v0hgt8MLkxSHeN1A49p4g6VCr-r8x7RGun9eVmtx0PZKgg@mail.gmail.com>
In-Reply-To: <CAJZ5v0hgt8MLkxSHeN1A49p4g6VCr-r8x7RGun9eVmtx0PZKgg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDJlMmVkMzYtMDdiMC00ZWNmLTk5NWUtMzExZmM2Zjg0MzcxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiI4VWtHSnlIaFVcL2NtSmZuN2pmY2lsNVorbEl3bmZWZ2dlYndocGpRMkhQYks0NWxtUEt5Q1owZktyckZwejY5bCJ9
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [10.22.254.138]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vB8LDPc2013803
Content-Length: 2223
Lines: 71

This type of thing more often than not is caused by running the code through indent (lindent).


Original ACPICA code:

    ACPI_FUNCTION_NAME (ExDumpOperand)

    /* Check if debug output enabled */

    if (!ACPI_IS_DEBUG_ENABLED (ACPI_LV_EXEC, _COMPONENT))
    {
        return;
    }


Raw "linuxized" code:

	ACPI_FUNCTION_NAME (ex_dump_operand)

	/* Check if debug output enabled */

	if (!ACPI_IS_DEBUG_ENABLED (ACPI_LV_EXEC, _COMPONENT)) {
		return;
	}


> -----Original Message-----
> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of
> Rafael J. Wysocki
> Sent: Friday, December 8, 2017 9:06 AM
> To: Vasyl Gomonovych <gomonovych@gmail.com>
> Cc: Moore, Robert <robert.moore@intel.com>; Zheng, Lv
> <lv.zheng@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>;
> Len Brown <lenb@kernel.org>; ACPI Devel Maling List <linux-
> acpi@vger.kernel.org>; devel@acpica.org; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; Schmauss, Erik <erik.schmauss@intel.com>
> Subject: Re: [PATCH] ACPICA: Fix indentation
> 
> On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych <gomonovych@gmail.com>
> wrote:
> > This patch avoids that smatch reports the following:
> > drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn:
> > inconsistent indenting
> >
> > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> 
> This is ACPICA code, so changes like this should go in via the upstream.
> 
> Erik may want to pick this up, however.
> 
> > ---
> >  drivers/acpi/acpica/exdump.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/acpica/exdump.c
> > b/drivers/acpi/acpica/exdump.c index 83398dc..f43d3d7 100644
> > --- a/drivers/acpi/acpica/exdump.c
> > +++ b/drivers/acpi/acpica/exdump.c
> > @@ -619,8 +619,8 @@ void acpi_ex_dump_operand(union
> > acpi_operand_object *obj_desc, u32 depth)
> >
> >         ACPI_FUNCTION_NAME(ex_dump_operand)
> >
> > -           /* Check if debug output enabled */
> > -           if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> > +       /* Check if debug output enabled */
> > +       if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> >                 return;
> >         }
> >
> > --