Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753442AbdLHWCt (ORCPT ); Fri, 8 Dec 2017 17:02:49 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44806 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752699AbdLHWCs (ORCPT ); Fri, 8 Dec 2017 17:02:48 -0500 Date: Fri, 8 Dec 2017 14:02:46 -0800 From: Andrew Morton To: Sergey Senozhatsky Cc: "Liu, Changcheng" , sergey.senozhatsky@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell Message-Id: <20171208140246.bc111cc726d5f7f8ff7c2ed2@linux-foundation.org> In-Reply-To: <20171208103315.GF628@jagdpanzerIV> References: <20171208093751.GA175471@sofia> <20171208103315.GF628@jagdpanzerIV> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 640 Lines: 19 On Fri, 8 Dec 2017 19:33:15 +0900 Sergey Senozhatsky wrote: > On (12/08/17 17:37), Liu, Changcheng wrote: > > > > On some linux distributions, the default link of sh > > is dash which deoesn't support split array like > > ${var//,/ } > > It's better to force to use bash shell directly. > > > > Signed-off-by: Liu Changcheng > > Reviewed-by: Sergey Senozhatsky It would be better to rewrite the script to avoid bashisms. But... akpm3:/usr/src/linux-4.15-rc2> grep -rl "/bin/bash" . | wc -l 164 I guess we lost that fight a long time ago.