Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753237AbdLHWNX (ORCPT ); Fri, 8 Dec 2017 17:13:23 -0500 Received: from smtprelay0208.hostedemail.com ([216.40.44.208]:56279 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752350AbdLHWNW (ORCPT ); Fri, 8 Dec 2017 17:13:22 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2551:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3873:3874:4250:4321:5007:7514:7576:7903:8957:9545:10004:10400:10848:11232:11658:11914:12043:12050:12296:12740:12760:12895:13069:13095:13311:13357:13436:13439:13846:14096:14097:14181:14659:14721:21080:21433:21434:21451:21627:30025:30054:30063:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: snail15_1d0e2d47a483d X-Filterd-Recvd-Size: 3137 Message-ID: <1512771198.1845.36.camel@perches.com> Subject: Re: [PATCH v2] drivers: visorbus: move driver out of staging From: Joe Perches To: "Kershner, David A" , Greg KH Cc: "jes.sorensen@gmail.com" , "linux-kernel@vger.kernel.org" , "driverdev-devel@linuxdriverproject.org" , *S-Par-Maintainer , "erik.arfvidson@gmail.com" , "wadgaonkarsam@gmail.com" Date: Fri, 08 Dec 2017 14:13:18 -0800 In-Reply-To: References: <1512666667-14981-1-git-send-email-david.kershner@unisys.com> <20171208153913.GA31823@kroah.com> <1512751979.1845.21.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1774 Lines: 51 On Fri, 2017-12-08 at 21:55 +0000, Kershner, David A wrote: > > -----Original Message----- > > From: Joe Perches [mailto:joe@perches.com] > > Sent: Friday, December 8, 2017 11:53 AM > > To: Greg KH ; Kershner, David A > > > > Cc: jes.sorensen@gmail.com; linux-kernel@vger.kernel.org; driverdev- > > devel@linuxdriverproject.org; *S-Par-Maintainer > > ; erik.arfvidson@gmail.com; > > wadgaonkarsam@gmail.com > > Subject: Re: [PATCH v2] drivers: visorbus: move driver out of staging > > > > On Fri, 2017-12-08 at 16:39 +0100, Greg KH wrote: > > > On Thu, Dec 07, 2017 at 12:11:07PM -0500, David Kershner wrote: > > > > Move the visorbus driver out of staging > > (drivers/staging/unisys/visorbus) > > > > and to drivers/visorbus. Modify the configuration and makefiles so > > they > > > > now reference the new location. The s-Par header file visorbus.h that > > is > > > > referenced by all s-Par drivers, is being moved into include/linux. > > > > Perhaps moving visorbus.h and visorbus_private.h to > > drivers/visorbus would be better than adding more > > relatively localized #include files to include/linux/ > > > > what about controlvmchannel? > > > > The file visorbus.h is currently included by 4 drivers: visorbus and 3 > other drivers that are staying in staging for now, but we plan to move out > soon. OK. Where do you plan on moving the 3 other drivers? Today, these drivers (visorhba, visorinput, and visornic) are all under the staging/unisys directory visorbus -> drivers/visorbus visorhba -> ? visorinput -> ? visornic -> ? Perhaps all these, including visorbus, should be under virt/ or perhaps visorbus should be under virt/ and the others under drivers/virt/