Message-ID: <1512771659.1845.40.camel@perches.com>
Subject: Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell
From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: "Liu, Changcheng" <changcheng.liu@intel.com>,
        sergey.senozhatsky@gmail.com, linux-kernel@vger.kernel.org
Date: Fri, 08 Dec 2017 14:20:59 -0800
In-Reply-To: <20171208140246.bc111cc726d5f7f8ff7c2ed2@linux-foundation.org>
References: <20171208093751.GA175471@sofia>
         <20171208103315.GF628@jagdpanzerIV>
         <20171208140246.bc111cc726d5f7f8ff7c2ed2@linux-foundation.org>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 854
Lines: 23

On Fri, 2017-12-08 at 14:02 -0800, Andrew Morton wrote:
> On Fri, 8 Dec 2017 19:33:15 +0900 Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:
> 
> > On (12/08/17 17:37), Liu, Changcheng wrote:
> > > 
> > > On some linux distributions, the default link of sh
> > > is dash which deoesn't support split array like
> > > ${var//,/ }
> > > It's better to force to use bash shell directly.
> > > 
> > > Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>
> > 
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> 
> It would be better to rewrite the script to avoid bashisms.  But...
> 
> akpm3:/usr/src/linux-4.15-rc2> grep -rl "/bin/bash" . | wc -l
> 164
> 
> I guess we lost that fight a long time ago.

103 of those are in tools/ and I don't think those count.
If you take out samples/ and Documentation/ it's down to 24.