Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753699AbdLHX7H (ORCPT ); Fri, 8 Dec 2017 18:59:07 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:47057 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753359AbdLHX7D (ORCPT ); Fri, 8 Dec 2017 18:59:03 -0500 X-Google-Smtp-Source: AGs4zMaxIR6p9loK8vEw/AQ9UdLKY3eahyJjpoHrMbKC1Q780vily1F8wS2/G8CJykzmYLxgiaOMfA== Date: Sat, 9 Dec 2017 08:59:00 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Sergey Senozhatsky , "Liu, Changcheng" , sergey.senozhatsky@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell Message-ID: <20171208235900.GE489@tigerII.localdomain> References: <20171208093751.GA175471@sofia> <20171208103315.GF628@jagdpanzerIV> <20171208140246.bc111cc726d5f7f8ff7c2ed2@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171208140246.bc111cc726d5f7f8ff7c2ed2@linux-foundation.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 617 Lines: 19 On (12/08/17 14:02), Andrew Morton wrote: > > On (12/08/17 17:37), Liu, Changcheng wrote: > > > > > > On some linux distributions, the default link of sh > > > is dash which deoesn't support split array like > > > ${var//,/ } > > > It's better to force to use bash shell directly. > > > > > > Signed-off-by: Liu Changcheng > > > > Reviewed-by: Sergey Senozhatsky > > It would be better to rewrite the script to avoid bashisms. Hello Andrew, what are the latest fashion trends? isn't it perl? so maybe I can sit down someday and rewrite it in perl. -ss