MIME-Version: 1.0
In-Reply-To: <20171208211702.20104-3-salil.mehta@huawei.com>
References: <20171208211702.20104-1-salil.mehta@huawei.com> <20171208211702.20104-3-salil.mehta@huawei.com>
From: Philippe Ombredanne <pombredanne@nexb.com>
Date: Sat, 9 Dec 2017 01:16:44 +0100
Message-ID: <CAOFm3uH0G7hA0kpiH+SivdLQ6hH_Prq7_gHg6O-hoaO94dPoTQ@mail.gmail.com>
Subject: Re: [PATCH V2 net-next 2/8] net: hns3: Add mailbox support to VF driver
To: Salil Mehta <salil.mehta@huawei.com>
Cc: "David S. Miller" <davem@davemloft.net>, yisen.zhuang@huawei.com,
        lipeng321@huawei.com, mehta.salil.lnk@gmail.com,
        netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        linux-rdma@vger.kernel.org, linuxarm@huawei.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1148
Lines: 34

Sali,

On Fri, Dec 8, 2017 at 10:16 PM, Salil Mehta <salil.mehta@huawei.com> wrote:
> This patch adds the support of the mailbox to the VF driver. The
> mailbox shall be used as an interface to communicate with the
> PF driver for various purposes like {set|get} MAC related
> operations, reset, link status etc. The mailbox supports both
> synchronous and asynchronous command send to PF driver.
>
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> Signed-off-by: lipeng <lipeng321@huawei.com>
[...]
> --- /dev/null
> +++ b/drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h
> @@ -0,0 +1,94 @@
> +/*
> + * Copyright (c) 2016-2017 Hisilicon Limited.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + */

Why not use the new SPDX ids?
e.g.
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/* Copyright (c) 2016-2017 Hisilicon Limited. */

See Linus posts and Thomas doc patches for details.

-- 
Cordially
Philippe Ombredanne