Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754176AbdLIATF (ORCPT ); Fri, 8 Dec 2017 19:19:05 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52042 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753061AbdLIASz (ORCPT ); Fri, 8 Dec 2017 19:18:55 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AF8B86081A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Fri, 8 Dec 2017 16:18:53 -0800 From: Stephen Boyd To: Abhishek Sahu Cc: Michael Turquette , Andy Gross , David Brown , Rajendra Nayak , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/13] clk: qcom: fix 16 bit alpha support calculation Message-ID: <20171209001853.GK7997@codeaurora.org> References: <1506621050-10129-1-git-send-email-absahu@codeaurora.org> <1506621050-10129-5-git-send-email-absahu@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506621050-10129-5-git-send-email-absahu@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 965 Lines: 26 On 09/28, Abhishek Sahu wrote: > The alpha value calculation function has been written for 40 bit > alpha which is not coming properly for 16 bit > > 1. Alpha value is being calculated on the basis of > ALPHA_BITWIDTH to make the computation easy for 40 bit alpha. > After calculating the 32 bit alpha, It is being converted to 40 > bit alpha by making making lower bits zero. But if actual alpha > register width is less than ALPHA_BITWIDTH, then the actual width > can be used for calculation > > 2. During 40 bit alpha pll set rate, the lower alpha register is > not being configured > > Now the changes have been made to calculate the rate and register > values from alpha_width instead hardcoding it so that it can work > for all the cases. > > Signed-off-by: Abhishek Sahu > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project