Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753027AbdLIAs3 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 8 Dec 2017 19:48:29 -0500
Received: from mail-it0-f50.google.com ([209.85.214.50]:41542 "EHLO
        mail-it0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752050AbdLIAs0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 8 Dec 2017 19:48:26 -0500
X-Google-Smtp-Source: AGs4zMY7LGnbiZlbbcJTbBVhggMVpp1UtHsef3unhk9Gf9fjP+HYtwk1CVRkPgkqJiFH6Ng+gXKxomZU/a818Gf+2Qg=
MIME-Version: 1.0
In-Reply-To: <20171208.112825.301687304435692797.davem@davemloft.net>
References: <CALOAHbBbo+ueVt7Wu=wAvgrfFjg7LVHfo4W_hhv_d7pQzeY9+Q@mail.gmail.com>
 <20171208.104256.1026704308758536035.davem@davemloft.net> <CALOAHbDNSaHqeQCSeNMfT7udN32VEciZA0bHgtt=coeXr4xj+g@mail.gmail.com>
 <20171208.112825.301687304435692797.davem@davemloft.net>
From: Yafang Shao <laoar.shao@gmail.com>
Date: Sat, 9 Dec 2017 08:47:45 +0800
Message-ID: <CALOAHbARM9bG+KDk_8_ypUEZp5+c_KZcMk+bsOVhMS4b8v2EjQ@mail.gmail.com>
Subject: Re: [PATCH v5 net-next] net/tcp: trace all TCP/IP state transition
 with tcp_set_state tracepoint
To: David Miller <davem@davemloft.net>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
        Song Liu <songliubraving@fb.com>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>, yoshfuji@linux-ipv6.org,
        Steven Rostedt <rostedt@goodmis.org>,
        Brendan Gregg <bgregg@netflix.com>, netdev@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1412
Lines: 50

2017-12-09 0:28 GMT+08:00 David Miller <davem@davemloft.net>:
> From: Yafang Shao <laoar.shao@gmail.com>
> Date: Fri, 8 Dec 2017 23:50:44 +0800
>
>> 2017-12-08 23:42 GMT+08:00 David Miller <davem@davemloft.net>:
>>> From: Yafang Shao <laoar.shao@gmail.com>
>>> Date: Fri, 8 Dec 2017 11:40:23 +0800
>>>
>>>> It will looks like these,
>>>>
>>>>     if (sk->sk_protocol == IPPROTO_TCP)
>>>>         __tcp_set_state(newsk, TCP_SYN_RECV);
>>>>     else
>>>>         newsk->sk_state = TCP_SYN_RECV;
>>>>
>>>>
>>>>     if (sk->sk_protocol == IPPROTO_TCP)
>>>>           __tcp_set_state(sk, TCP_CLOSE);
>>>>     else
>>>>           sk->sk_state = TCP_CLOSE;
>>>>
>>>>     if (sk->sk_protocol == IPPROTO_TCP)
>>>>           tcp_state_store(sk,  state);
>>>>     else
>>>>           sk_state_store(sk, state);
>>>>
>>>>
>>>> Some redundant code.
>>>>
>>>> IMO, put these similar code into a wrapper is more nice.
>>>
>>> I think this discussion and how ugly this is getting shows that
>>> tracing the state transitions of a socket is perhaps not best as a TCP
>>> specific feature.
>>
>> Do you mean that tcp_set_state tracepoint should be replaced with
>> sk_set_state tracepoint and move that tracepoint to
>> trace/events/sock.h ?
>
> Yes, something like that.
>
> It will avoid all of these protocol specific checks and weird
> dependencies.

That looks like a good idea.
I will try to reimplemnet it.


Thanks
Yafang