Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751109AbdLIGRX (ORCPT ); Sat, 9 Dec 2017 01:17:23 -0500 Received: from omzsmtpe01.verizonbusiness.com ([199.249.25.210]:26684 "EHLO omzsmtpe01.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750930AbdLIGRV (ORCPT ); Sat, 9 Dec 2017 01:17:21 -0500 From: alexander.levin@verizon.com X-Host: pioneer.tdc.vzwcorp.com To: Ben Hutchings CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Ben Hutchings , Shuah Khan Subject: Re: [PATCH 4.4 20/49] usbip: tools: Install all headers needed for libusbip development Thread-Topic: [PATCH 4.4 20/49] usbip: tools: Install all headers needed for libusbip development Thread-Index: AQHTcLUxewk3fMrOPUCCFoH0a9asyg== Date: Sat, 9 Dec 2017 06:16:04 +0000 Message-ID: <20171209061602.lvnxuqvnlihoz6wc@sasha-lappy> References: <20171207124703.742654162@linuxfoundation.org> <20171207124706.647290027@linuxfoundation.org> <1512705400.18523.227.camel@codethink.co.uk> In-Reply-To: <1512705400.18523.227.camel@codethink.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: NeoMutt/20170113 (1.7.2) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] Content-Type: text/plain; charset="iso-8859-1" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vB96HTNm032275 Content-Length: 1734 Lines: 48 On Fri, Dec 08, 2017 at 03:56:40AM +0000, Ben Hutchings wrote: >On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote: >> 4.4-stable review patch.??If anyone has any objections, please let me know. >> >> ------------------ >> >> From: Ben Hutchings >> >> >> [ Upstream commit c15562c0dcb2c7f26e891923b784cf1926b8c833 ] >> >> usbip_host_driver.h now depends on several additional headers, which >> need to be installed along with it. >> >> Fixes: 021aed845303 ("staging: usbip: userspace: migrate usbip_host_driver ...") >> Fixes: 3391ba0e2792 ("usbip: tools: Extract generic code to be shared with ...") >> Signed-off-by: Ben Hutchings >> Acked-by: Shuah Khan >> Signed-off-by: Greg Kroah-Hartman >> Signed-off-by: Sasha Levin >> Signed-off-by: Greg Kroah-Hartman >> --- >> ?tools/usb/usbip/Makefile.am |????3 ++- >> ?1 file changed, 2 insertions(+), 1 deletion(-) >> >> --- a/tools/usb/usbip/Makefile.am >> +++ b/tools/usb/usbip/Makefile.am >> @@ -1,6 +1,7 @@ >> ?SUBDIRS := libsrc src >> ?includedir = @includedir@/usbip >> ?include_HEADERS := $(addprefix libsrc/, \ >> - ?????usbip_common.h vhci_driver.h usbip_host_driver.h) >> + ?????usbip_common.h vhci_driver.h usbip_host_driver.h \ >> + ?????list.h sysfs_utils.h usbip_host_common.h) > >usbip_host_common.h was added in 4.7 (by the second commit listed >above), so?for 4.4 and 3.18 it should not be added to this list. Thanks Ben! Greg, I'm not sure how to send you fixes for patches currently in your -rc cycle, since ideally you would just remove them instead of reverting. Any ideas? -- Thanks, Sasha