Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751229AbdLII3x (ORCPT ); Sat, 9 Dec 2017 03:29:53 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36692 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbdLII3w (ORCPT ); Sat, 9 Dec 2017 03:29:52 -0500 X-Google-Smtp-Source: AGs4zMZpmVyh8OhbQ4nnU7zm/ninIPghHb7q438KcpokdBLSaXuN/WxRhaqq8dmT8okDTeJn8ZapFVGlOFqv38cw6dA= MIME-Version: 1.0 In-Reply-To: <20171209064953.8984-3-jiaxun.yang@flygoat.com> References: <20171209064953.8984-1-jiaxun.yang@flygoat.com> <20171209064953.8984-3-jiaxun.yang@flygoat.com> From: Philippe Ombredanne Date: Sat, 9 Dec 2017 09:29:10 +0100 Message-ID: Subject: Re: [PATCH v4 2/5] MIPS: Loongson64: lemote-2f move ec_kb3310b.h to include dir and clean up To: Jiaxun Yang Cc: James Hogan , Ralf Baechle , linux-mips@linux-mips.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1905 Lines: 47 Dea Jiaxun, On Sat, Dec 9, 2017 at 7:49 AM, Jiaxun Yang wrote: > To operate EC from platform driver, this head file need able to be include > from anywhere. This patch just move ec_kb3310b.h to include dir and > clean up ec_kb3310b.h. > > Signed-off-by: Jiaxun Yang > --- > arch/mips/include/asm/mach-loongson64/ec_kb3310b.h | 170 +++++++++++++++++++ > arch/mips/loongson64/lemote-2f/ec_kb3310b.c | 2 +- > arch/mips/loongson64/lemote-2f/ec_kb3310b.h | 188 --------------------- > arch/mips/loongson64/lemote-2f/pm.c | 4 +- > arch/mips/loongson64/lemote-2f/reset.c | 4 +- > 5 files changed, 175 insertions(+), 193 deletions(-) > create mode 100644 arch/mips/include/asm/mach-loongson64/ec_kb3310b.h > delete mode 100644 arch/mips/loongson64/lemote-2f/ec_kb3310b.h > > diff --git a/arch/mips/include/asm/mach-loongson64/ec_kb3310b.h b/arch/mips/include/asm/mach-loongson64/ec_kb3310b.h > new file mode 100644 > index 000000000000..2e8690532ea5 > --- /dev/null > +++ b/arch/mips/include/asm/mach-loongson64/ec_kb3310b.h > @@ -0,0 +1,170 @@ > +/* > + * KB3310B Embedded Controller > + * > + * Copyright (C) 2008 Lemote Inc. > + * Author: liujl , 2008-03-14 > + * Copyright (C) 2009 Lemote Inc. > + * Author: Wu Zhangjin > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + */ Have you considered using the new SPDX ids instead of this fine but long license boilerplate? That would be very gentle of you if you did! You can check Thomas documentation patches, as well as Linus comments on the topic. -- Cordially Philippe Ombredanne