Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751609AbdLIRE5 (ORCPT ); Sat, 9 Dec 2017 12:04:57 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48528 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbdLIREv (ORCPT ); Sat, 9 Dec 2017 12:04:51 -0500 Date: Sat, 9 Dec 2017 18:04:58 +0100 From: Greg Kroah-Hartman To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ross Lagerwall , Boris Ostrovsky , "David S. Miller" , Sasha Levin Subject: Re: [PATCH 4.4 38/49] xen-netfront: Improve error handling during initialization Message-ID: <20171209170458.GD27604@kroah.com> References: <20171207124703.742654162@linuxfoundation.org> <20171207124709.059301507@linuxfoundation.org> <1512709849.18523.245.camel@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1512709849.18523.245.camel@codethink.co.uk> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 38 On Fri, Dec 08, 2017 at 05:10:49AM +0000, Ben Hutchings wrote: > On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch.??If anyone has any objections, please let me > > know. > > > > ------------------ > > > > From: Ross Lagerwall > > > > > > [ Upstream commit e2e004acc7cbe3c531e752a270a74e95cde3ea48 ] > [...] > > @@ -1950,9 +1942,10 @@ abort_transaction_no_dev_fatal: > > ? xenbus_transaction_end(xbt, 1); > > ? destroy_ring: > > ? xennet_disconnect_backend(info); > > - kfree(info->queues); > > - info->queues = NULL; > > + xennet_destroy_queues(info); > > ? out: > > + unregister_netdev(info->netdev); > > + xennet_free_netdev(info->netdev); > > ? return err; > > ?} > > This last bit of cleanup looks wrong. It was subsequently changed > upstream by: > > 86b5672b1adb xen-netfront: avoid crashing on resume after a failure in talk_to_netback() Good catch, but it's d86b5672b1ad ("xen-netfront: avoid crashing on resume after a failure in talk_to_netback()") :) thanks, greg k-h