Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752196AbdLIRGL (ORCPT ); Sat, 9 Dec 2017 12:06:11 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48662 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbdLIRGJ (ORCPT ); Sat, 9 Dec 2017 12:06:09 -0500 Date: Sat, 9 Dec 2017 18:06:16 +0100 From: Greg Kroah-Hartman To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ben Hutchings , Shuah Khan , Sasha Levin Subject: Re: [PATCH 4.4 20/49] usbip: tools: Install all headers needed for libusbip development Message-ID: <20171209170616.GF27604@kroah.com> References: <20171207124703.742654162@linuxfoundation.org> <20171207124706.647290027@linuxfoundation.org> <1512705400.18523.227.camel@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1512705400.18523.227.camel@codethink.co.uk> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1671 Lines: 43 On Fri, Dec 08, 2017 at 03:56:40AM +0000, Ben Hutchings wrote: > On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch.??If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Ben Hutchings > > > > > > [ Upstream commit c15562c0dcb2c7f26e891923b784cf1926b8c833 ] > > > > usbip_host_driver.h now depends on several additional headers, which > > need to be installed along with it. > > > > Fixes: 021aed845303 ("staging: usbip: userspace: migrate usbip_host_driver ...") > > Fixes: 3391ba0e2792 ("usbip: tools: Extract generic code to be shared with ...") > > Signed-off-by: Ben Hutchings > > Acked-by: Shuah Khan > > Signed-off-by: Greg Kroah-Hartman > > Signed-off-by: Sasha Levin > > Signed-off-by: Greg Kroah-Hartman > > --- > > ?tools/usb/usbip/Makefile.am |????3 ++- > > ?1 file changed, 2 insertions(+), 1 deletion(-) > > > > --- a/tools/usb/usbip/Makefile.am > > +++ b/tools/usb/usbip/Makefile.am > > @@ -1,6 +1,7 @@ > > ?SUBDIRS := libsrc src > > ?includedir = @includedir@/usbip > > ?include_HEADERS := $(addprefix libsrc/, \ > > - ?????usbip_common.h vhci_driver.h usbip_host_driver.h) > > + ?????usbip_common.h vhci_driver.h usbip_host_driver.h \ > > + ?????list.h sysfs_utils.h usbip_host_common.h) > > usbip_host_common.h was added in 4.7 (by the second commit listed > above), so?for 4.4 and 3.18 it should not be added to this list. Thanks, now dropped from those trees. Many thanks for the great review. greg k-h