Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751263AbdLIRkY (ORCPT ); Sat, 9 Dec 2017 12:40:24 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:51800 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbdLIRkT (ORCPT ); Sat, 9 Dec 2017 12:40:19 -0500 Date: Sat, 9 Dec 2017 18:40:26 +0100 From: Greg KH To: Joe Perches Cc: "Kershner, David A" , "jes.sorensen@gmail.com" , "linux-kernel@vger.kernel.org" , "driverdev-devel@linuxdriverproject.org" , *S-Par-Maintainer , "erik.arfvidson@gmail.com" , "wadgaonkarsam@gmail.com" Subject: Re: [PATCH v2] drivers: visorbus: move driver out of staging Message-ID: <20171209174026.GA10709@kroah.com> References: <1512666667-14981-1-git-send-email-david.kershner@unisys.com> <20171208153913.GA31823@kroah.com> <1512751979.1845.21.camel@perches.com> <1512771198.1845.36.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512771198.1845.36.camel@perches.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2057 Lines: 59 On Fri, Dec 08, 2017 at 02:13:18PM -0800, Joe Perches wrote: > On Fri, 2017-12-08 at 21:55 +0000, Kershner, David A wrote: > > > -----Original Message----- > > > From: Joe Perches [mailto:joe@perches.com] > > > Sent: Friday, December 8, 2017 11:53 AM > > > To: Greg KH ; Kershner, David A > > > > > > Cc: jes.sorensen@gmail.com; linux-kernel@vger.kernel.org; driverdev- > > > devel@linuxdriverproject.org; *S-Par-Maintainer > > > ; erik.arfvidson@gmail.com; > > > wadgaonkarsam@gmail.com > > > Subject: Re: [PATCH v2] drivers: visorbus: move driver out of staging > > > > > > On Fri, 2017-12-08 at 16:39 +0100, Greg KH wrote: > > > > On Thu, Dec 07, 2017 at 12:11:07PM -0500, David Kershner wrote: > > > > > Move the visorbus driver out of staging > > > > (drivers/staging/unisys/visorbus) > > > > > and to drivers/visorbus. Modify the configuration and makefiles so > > > > they > > > > > now reference the new location. The s-Par header file visorbus.h that > > > > is > > > > > referenced by all s-Par drivers, is being moved into include/linux. > > > > > > Perhaps moving visorbus.h and visorbus_private.h to > > > drivers/visorbus would be better than adding more > > > relatively localized #include files to include/linux/ > > > > > > what about controlvmchannel? > > > > > > > The file visorbus.h is currently included by 4 drivers: visorbus and 3 > > other drivers that are staying in staging for now, but we plan to move out > > soon. > > OK. > > Where do you plan on moving the 3 other drivers? > > Today, these drivers (visorhba, visorinput, and visornic) > are all under the staging/unisys directory > > visorbus -> drivers/visorbus > visorhba -> ? > visorinput -> ? > visornic -> ? > > Perhaps all these, including visorbus, should be under virt/ > or perhaps visorbus should be under virt/ and the others > under drivers/virt/ They will move to the proper subsystem directory (storage, input, networking), when they are ready. thanks, greg k-h