Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751365AbdLISji (ORCPT ); Sat, 9 Dec 2017 13:39:38 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:40475 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbdLISjg (ORCPT ); Sat, 9 Dec 2017 13:39:36 -0500 X-Google-Smtp-Source: AGs4zMZHB1cxTH9YcQ+aEHWwrtQSCkqGxODI84IQ5gbPuFYdEpEfpP6EfXwLnOpI0l68mRDWgut19GTZZUddsTQq9QQ= MIME-Version: 1.0 In-Reply-To: <20171209171349.GA26021@kroah.com> References: <20171207130818.742746317@linuxfoundation.org> <20171209074544.GA1770@kroah.com> <20171209171349.GA26021@kroah.com> From: Ivan Kozik Date: Sat, 9 Dec 2017 18:39:02 +0000 Message-ID: Subject: Re: [PATCH 4.14 00/75] 4.14.5-stable review To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Linus Torvalds , akpm@linux-foundation.org, Guenter Roeck , Shuah Khan , patches@kernelci.org, Ben Hutchings , lkft-triage@lists.linaro.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1594 Lines: 44 On Sat, Dec 9, 2017 at 5:13 PM, Greg Kroah-Hartman wrote: > On Sat, Dec 09, 2017 at 07:56:40AM +0000, Ivan Kozik wrote: >> On Sat, Dec 9, 2017 at 7:45 AM, Greg Kroah-Hartman >> wrote: >> > On Sat, Dec 09, 2017 at 03:34:24AM +0000, Ivan Kozik wrote: >> >> I saw no problems on 8 of 9 machines, but the last one had a problem >> >> because it used NVIDIA drivers (387); DKMS reported: >> >> >> >> FATAL: modpost: GPL-incompatible module nvidia-drm.ko uses GPL-only >> >> symbol 'ex_handler_refcount' >> >> //usr/src/linux-headers-4.14.0-11-common/scripts/Makefile.modpost:92: >> >> recipe for target '__modpost' failed >> >> make[3]: *** [__modpost] Error 1 >> > >> > Is this a new issue? Does 4.14.4 have this issue? >> >> I believe it is a new issue, because I have a 4.14.4 build and an >> NVIDIA DKMS log for that 4.14.4 showing build success. >> >> > Odd, is 564c9cc84e2a ("locking/refcounts, x86/asm: Use unique .text >> > section for refcount exceptions") causing this? >> >> That was my guess too, but I did not verify. > > That feels really wrong here, I'd like to get some confirmation before I > add this patch... I built a 4.14.4 with all the stable-queue patches except: locking/refcounts, x86/asm: Enable CONFIG_ARCH_HAS_REFCOUNT and NVIDIA built fine with DKMS, so it looks like the refcount enablement patch was responsible. In summary, NVIDIA builds fine with 4.14.4 4.14.4 + all stable-queue except ...Enable CONFIG_ARCH_HAS_REFCOUNT 4.14.4 + all stable-queue + https://lkml.org/lkml/2017/12/4/1110 Thanks, Ivan