Date: Sat, 9 Dec 2017 21:50:22 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
        devel@linuxdriverproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hyperv: make HYPERV a menuconfig to ease disabling it
 all
Message-ID: <20171209215022.6795dd91@xeon-e3>
In-Reply-To: <20171209152151.4341-1-vincent.legoll@gmail.com>
References: <20171209152151.4341-1-vincent.legoll@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1142
Lines: 39

On Sat,  9 Dec 2017 16:21:51 +0100
Vincent Legoll <vincent.legoll@gmail.com> wrote:

> No need to get into the submenu to disable all HYPERV-related
> config entries.
> 
> This makes it easier to disable all HYPERV config options
> without entering the submenu. It will also enable one
> to see that en/dis-abled state from the outside menu.
> 
> This is only intended to change menuconfig UI, not change
> the config dependencies.
> 
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
> ---
>  drivers/hv/Kconfig | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig
> index 50b89ea0e60f..5804081d936d 100644
> --- a/drivers/hv/Kconfig
> +++ b/drivers/hv/Kconfig
> @@ -1,4 +1,7 @@
> -menu "Microsoft Hyper-V guest support"
> +menuconfig HYPERV_MENU
> +	bool "Microsoft Hyper-V guest support"
> +
> +if HYPERV_MENU
>  
>  config HYPERV
>  	tristate "Microsoft Hyper-V client drivers"
> @@ -23,4 +26,4 @@ config HYPERV_BALLOON
>  	help
>  	  Select this option to enable Hyper-V Balloon driver.
>  
> -endmenu
> +endif # HYPERV_MENU

Will this break existing configs?