Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752255AbdLJSmz (ORCPT ); Sun, 10 Dec 2017 13:42:55 -0500 Received: from mail-ot0-f195.google.com ([74.125.82.195]:46942 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994AbdLJSmx (ORCPT ); Sun, 10 Dec 2017 13:42:53 -0500 X-Google-Smtp-Source: AGs4zMYVbzx5V8Ex7JDXIICOeq88zrwgBFk0ALzV5sCSy9E6w2+59xzvOh3fD9SKk2jBai8nvh9hhkTAuAYPTB90Qp8= MIME-Version: 1.0 In-Reply-To: References: <20171207133915.29448-1-brgl@bgdev.pl> <20171207133915.29448-2-brgl@bgdev.pl> From: Bartosz Golaszewski Date: Sun, 10 Dec 2017 19:42:52 +0100 Message-ID: Subject: Re: [PATCH v3 1/2] eeprom: at24: fix coding style issues To: Andy Shevchenko Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Peter Rosin , linux-i2c , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 546 Lines: 19 2017-12-10 13:57 GMT+01:00 Andy Shevchenko : > On Thu, Dec 7, 2017 at 3:39 PM, Bartosz Golaszewski wrote: >> Fix issues reported by checkpatch for at24.c. > >> +module_param(io_limit, uint, 0000); > >> +module_param(write_timeout, uint, 0000); > > > 0 is a pretty much octal number as 0000. > So, I would prefer not to blindly follow the stupid advise from > checkpatch, better to teach checkpatch about 0. > > I submitted a patch for that - let's see what checkpatch maintainers say. Thanks, Bartosz