Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752330AbdLJS4o (ORCPT ); Sun, 10 Dec 2017 13:56:44 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:48702 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751991AbdLJS4l (ORCPT ); Sun, 10 Dec 2017 13:56:41 -0500 Date: Sun, 10 Dec 2017 19:56:38 +0100 From: Pavel Machek To: Linus Torvalds , luto@kernel.org, tglx@linutronix.de, jarkko.nikula@linux.intel.com Cc: "Rafael J. Wysocki" , Thomas Gleixner , Andy Lutomirski , Linux Kernel Mailing List , the arch/x86 maintainers Subject: Re: Linux 4.15-rc2: Regression in resume from ACPI S3 Message-ID: <20171210185638.GA10363@amd> References: <2809506.pL8kVbvXcY@aspire.rjw.lan> <1578405.51lzoSX1jh@aspire.rjw.lan> <20171209103325.GA13867@amd> <20171209220110.GA11496@amd> <20171210162305.GA10159@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2377 Lines: 72 --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun 2017-12-10 08:37:56, Linus Torvalds wrote: > On Sun, Dec 10, 2017 at 8:23 AM, Pavel Machek wrote: > > > > Can you do something about html emails? Quoting them doesn't work too w= ell. >=20 > Yeah, and they don't show up onlkml either because of rules. I try to > avoid them, but have been more on mobile for various reasons lately > than usual. That should be over and done with after today, though. >=20 > >> Any chance to bisect it? This doesn't sound like the other problem > >> we had. > > > > Let me try... > > > > v4.15-rc2: suspends/resumes ok. > > 4ded3be: hangs on resume. > > > > Given that between those, there was supposed "fix" for suspend, I > > believe I should try reverting that one first. .. if someone can tell > > me commit id, that would help. >=20 > The fix in there should be 5b06bbcfc2c6 ("x86/power: Fix some ordering > bugs in __restore_processor_context()") so you can certainly see if it > works before that (or just reverting it). Revert is easier. > But there are also a few other x86 low-level things there, and that > fix really looks very safe, so I'd almost expect something else to > have triggered your problem. There's less than 500 commits in that > range you have, so a few bisections should narrow it down a lot. No, that commit does _look_ pretty suspect to me... Confirmed, revert fixes it. You see how it moves fix_processor_context around #ifdef CONFIG_X86_32 block? And how people forget 32-bit machines exist? Aha. Which brings me to .. various people do automated testing of kernel. Testing 32-bit kernel for boot, and both 32-bit and 64-bit for boot and suspend would be very nice. The last item is not hard, either: sudo rtcwake -l -m mem -s 5 =2E..should take 10 seconds or so.=20 Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlotg2YACgkQMOfwapXb+vLNUwCeNgiFGiT9yxraCYaGZoYpJuyb JWsAn1nW1ETM+yRyuy0MSCeceLoK8epv =9Tey -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd--