Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752204AbdLKHPS (ORCPT ); Mon, 11 Dec 2017 02:15:18 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:51801 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbdLKHPP (ORCPT ); Mon, 11 Dec 2017 02:15:15 -0500 Date: Mon, 11 Dec 2017 08:15:13 +0100 From: Maxime Ripard To: =?iso-8859-1?Q?Myl=E8ne?= Josserand Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, wens@csie.org, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, simon.budig@kernelconcepts.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@free-electrons.com Subject: Re: [PATCH 1/5] arm: dts: sun8i: a83t: Add I2C0 node Message-ID: <20171211071513.xgni3t6ihmeeebre@flea.lan> References: <20171208215419.30396-1-mylene.josserand@free-electrons.com> <20171208215419.30396-2-mylene.josserand@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7mew5amzvozgr3w3" Content-Disposition: inline In-Reply-To: <20171208215419.30396-2-mylene.josserand@free-electrons.com> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2017 Lines: 66 --7mew5amzvozgr3w3 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Dec 08, 2017 at 10:54:15PM +0100, Myl=E8ne Josserand wrote: > Add I2C0 node for A83T. >=20 > Signed-off-by: Myl=E8ne Josserand > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-= a83t.dtsi > index 19acae1b4089..848cf3f19962 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -177,6 +177,17 @@ > #dma-cells =3D <1>; > }; > =20 > + i2c0: i2c@01c2ac00 { Drop the leading 0, it generates a warning in dtc. > + compatible =3D "allwinner,sun6i-a31-i2c"; Can you add a SoC-specific compatible there please? > + reg =3D <0x01c2ac00 0x400>; And you should order your nodes by physical address. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --7mew5amzvozgr3w3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlouMG4ACgkQ0rTAlCFN r3SFSQ//SmWtanFavf2njXBSWdiV4WzofrO19jkgxy9m15Q2N6QsqlXG55CdFyWZ YiH2PCVExuXs2g9011yDp83RcL3FxM/C9K17ouSw4F8DB+tCEHVB+KV/tlzTHXJN XZ74+yBlFSnZA+T/S2s1j/cNU5sLIOE0O+E8unkhA30h52rGGB6A/UGVGY5iQFpU +iu8UsFKWHueHxp/i+elXVjomGMXdImcSmnGczaIg9dU+hrtyPuEOdpGElMkOEiG 2Gsyy1jXsovlXgY3TDWPAdfQUWZiSmHnhXkE2hX6r1lRhvitdEJbtMBjhqGgb/OJ kjtNEO7R9ktWkIomusLjBT1VxDODbdntPMClez4ZaUNPsK9hOyBQ9aG3fULeSLLK wbqozA97PGAwq7pm32vM91inyfUbSoY1P3oYglK1O1NfVfCYTOn1o54WLoT4wiZh Dc/AZASek2fGkxhqxn9IXw06lWkJsPo2HuQ3/wNuQ12KEngTNEBdC9KrsbZAUXSp GeqcXPGnuEDkltT0ZC5saUg6ClGUqtJcWgd8Xrwaw5m750IYFbNJsFSPg6eUlktC Cs254EEvsqMDJAdnMniIz6LgnV8WH/3LSAaf+ma6buaMek3ygk0JOWL9MnlzZNVq VzUezZRsX6IpAMyoaC5ruEGwz1zgvnDzCEF4c/kv3dv67N1+N5w= =0jog -----END PGP SIGNATURE----- --7mew5amzvozgr3w3--