Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752354AbdLKHQi (ORCPT ); Mon, 11 Dec 2017 02:16:38 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:51876 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbdLKHQg (ORCPT ); Mon, 11 Dec 2017 02:16:36 -0500 Date: Mon, 11 Dec 2017 08:16:35 +0100 From: Maxime Ripard To: =?iso-8859-1?Q?Myl=E8ne?= Josserand Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, wens@csie.org, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, simon.budig@kernelconcepts.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@free-electrons.com Subject: Re: [PATCH 5/5] arm: dts: sun8i: a83t: a711: Add touchscreen node Message-ID: <20171211071635.4ntdksmjino4uh2i@flea.lan> References: <20171208215419.30396-1-mylene.josserand@free-electrons.com> <20171208215419.30396-6-mylene.josserand@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wiz72sqo6qhqdtvk" Content-Disposition: inline In-Reply-To: <20171208215419.30396-6-mylene.josserand@free-electrons.com> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2188 Lines: 64 --wiz72sqo6qhqdtvk Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Dec 08, 2017 at 10:54:19PM +0100, Myl=E8ne Josserand wrote: > Tha A711 tablet has a FocalTech EDT-FT5x06 Polytouch touchscreen. > It is connected via I2C0 so add his node in i2c0's node. >=20 > The reset line is PD5, the interrupt line is PL7 and the power > supply is the ldo_io0 regulator. >=20 > Signed-off-by: Myl=E8ne Josserand > --- > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dt= s/sun8i-a83t-tbs-a711.dts > index 84cca1a48cea..738359917a34 100644 > --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > @@ -110,6 +110,17 @@ > pinctrl-0 =3D <&i2c0_pins>; > clock-frequency =3D <400000>; > status =3D "okay"; > + > + polytouch: edt-ft5x06@38 { You're not using that label anywhere, so you can drop it, and the node name must be the class of the device. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --wiz72sqo6qhqdtvk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlouMM8ACgkQ0rTAlCFN r3R1zw//aRFpquavLrgR9AuPEmGk7PvCAvv+jUsoFmg/La2tOYZBWoUCht9l7kzc U064V8gnUHv/Ux5rXedlDjD+mJN4BUnWlZCOWXVYzv1jqSLkNd2jKpBHzhQpKNZf 890QSGi871/KxkwghDplpfAeVCZe4M5QxYfSFotOuAlYqER1YJ6ize+FqAfilieD cxJvYjVs1OuKP1Z/tEGR8Y+dS9JhFkNMkcS7VDNgpKW13Ksm6ZUtLCOCYBztfO6D bx7y2a6duFzMPiJVDWvWeXVw4pQe7GKLF47LXJmr69S74ETeOWYws29wP3uhirUv lhNuwZ+d79kYfsO8XZZ/+XshcgnpwQ5C8EDC30YkAJwJztN2U6ytZkpMakTTUDyu tH0MQ6aVzM3oYrAOa2XCXZBIoBAWuv2gHOyphp38yM/VriFOFQBW4+2AYM6Hvn+P IhJLiN23KrfJ1x7em4VCGgAsVkYcYXt0DST6ivmBc2v90M9xwuFi47flaGSLYuUd Y91kxxmoQ0NUK9ljq6tK0CBb7Ydv4Ol3iwwiXszV/IZFoKnzjOkxxnSXLMZ/S2QY +P6GIuXnYx0Gm/hi0NVDDOwiuIOLKgifhk3W2FNmLnrg6pMlzLFNQogP5KvbQ/tI oo3xTcyoVXQBuq3NmNT9XRuj7lUtITOJgAjpJhfoaAJeYbGp2Ww= =1zuM -----END PGP SIGNATURE----- --wiz72sqo6qhqdtvk--