Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165AbdLKHei (ORCPT ); Mon, 11 Dec 2017 02:34:38 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:51918 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbdLKHeg (ORCPT ); Mon, 11 Dec 2017 02:34:36 -0500 Date: Mon, 11 Dec 2017 08:34:43 +0100 From: Greg Kroah-Hartman To: Yinbo Zhu Cc: Felipe Balbi , Mathias Nyman , "open list:DESIGNWARE USB3 DRD IP DRIVER" , "open list:DESIGNWARE USB3 DRD IP DRIVER" , open list , Xiaobo Xie , Jerry Huang , Ran Wang Subject: Re: [PATCH v2] usb: host: Implement workaround for Erratum A-009611 Message-ID: <20171211073443.GB7712@kroah.com> References: <20171208094942.46748-1-yinbo.zhu@nxp.com> <20171208094942.46748-2-yinbo.zhu@nxp.com> <20171208102111.GA16245@kroah.com> <87vahhpkhw.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2557 Lines: 54 On Mon, Dec 11, 2017 at 03:15:37AM +0000, Yinbo Zhu wrote: > > > -----Original Message----- > From: Felipe Balbi [mailto:felipe.balbi@linux.intel.com] > Sent: Friday, December 08, 2017 6:44 PM > To: Greg Kroah-Hartman ; Yinbo Zhu > Cc: Mathias Nyman ; open list:DESIGNWARE USB3 DRD IP DRIVER ; open list:DESIGNWARE USB3 DRD IP DRIVER ; open list ; Xiaobo Xie ; Jerry Huang ; Ran Wang > Subject: Re: [PATCH v2] usb: host: Implement workaround for Erratum A-009611 > > > >Hi, > > >Greg Kroah-Hartman writes: > > On Fri, Dec 08, 2017 at 05:49:41PM +0800, yinbo.zhu@nxp.com wrote: > >> From: "yinbo.zhu" > >> > >> Description: This is a occasional problem where the software > > > > No need for a "Description:" word. That's just assumed here, right? > > I will remove "Description:" thanks. > >> issues an End Transfer command while a USB transfer is in progress, > >> resulting in the TxFIFO being flushed when the lower layer is > >> waiting for data,causing the super speed (SS) transmit to get blocked. > >> If the End Transfer command is issued on an IN endpoint to flush out > >> the pending transfers when the same IN endpoint is doing transfers on > >> the USB, then depending upon the timing of the End Transfer (and the > >> resulting internal FIFO flush),the lower layer (U3PTL/U3MAC) could > >> get stuck waiting for data indefinitely. This blocks the transmission > >> path on the SS, and no DP/ACK/ERDY/DEVNOTIF packets can be sent from > >> the device. > >> Impact: If this issue happens and the transmission gets blocked, then > >> the USB host aborts and resets/re-enumerates the device. > >> This unblocks the transmitt engine and the device functions normally. > >> > >> Workaround: Software must wait for all existing TRBs to complete > >> before issuing End transfer command. > >> > >> Configs Affected: > >> LS1088-48A-R1.0, LS2081A-R1.1, LS2088-48A-R1.0, LS2088-48A-R1.1, > >> LX2160-2120-2080A-R1. > > > > What are these Configs? That doesn't seem to match up with anything > > that is in the kernel tree that I can see. > > These configs is soc information, I don't enable it on these platform dts. > Although the erratum issue can't be reproduced. I do not understand what this means, please explain it a bit better. thanks, greg k-h