Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752310AbdLKIIW (ORCPT ); Mon, 11 Dec 2017 03:08:22 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:38351 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbdLKIIR (ORCPT ); Mon, 11 Dec 2017 03:08:17 -0500 X-Google-Smtp-Source: AGs4zMa6S/xVTbH21yxkv7v9el47oBjO26eIULMLuHA+6HFVVctm4MJ6Eu0aSPeKdQVGaB6G6lSl0XFxrk4Fh5sQa9Q= MIME-Version: 1.0 In-Reply-To: References: <1512641861-5113-1-git-send-email-geert+renesas@glider.be> From: Geert Uytterhoeven Date: Mon, 11 Dec 2017 09:08:15 +0100 X-Google-Sender-Auth: R8uJMCHEskEld_e23RzJl2hompY Message-ID: Subject: Re: [PATCH] mm/slab: Do not hash pointers when debugging slab To: Linus Torvalds Cc: Geert Uytterhoeven , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , "Tobin C . Harding" , linux-mm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 30 Hi Linus, On Sun, Dec 10, 2017 at 9:45 PM, Linus Torvalds wrote: > On Thu, Dec 7, 2017 at 2:17 AM, Geert Uytterhoeven > wrote: >> - pr_err("Slab corruption (%s): %s start=%p, len=%d\n", >> + pr_err("Slab corruption (%s): %s start=%px, len=%d\n", >> print_tainted(), cachep->name, >> realobj, size); > > and here, is the pointer actually interesting, or should we just give > the offset to the allocation? The pointer may help to identify e.g. an empty list_head in the written data. > But if the pointer is interesting, then ack. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds