Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752434AbdLKIbw convert rfc822-to-8bit (ORCPT ); Mon, 11 Dec 2017 03:31:52 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:44500 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbdLKIbt (ORCPT ); Mon, 11 Dec 2017 03:31:49 -0500 X-Google-Smtp-Source: AGs4zMYjFGSueCID6tM0wzm89Dhm1MT9iETUhyq/Mgc/gy5r8QzVH1rL0ojWKRH3RlTgTNvnGL/oWwcUiJy9Bsf4Fms= MIME-Version: 1.0 In-Reply-To: <20171211071513.xgni3t6ihmeeebre@flea.lan> References: <20171208215419.30396-1-mylene.josserand@free-electrons.com> <20171208215419.30396-2-mylene.josserand@free-electrons.com> <20171211071513.xgni3t6ihmeeebre@flea.lan> From: Chen-Yu Tsai Date: Mon, 11 Dec 2017 16:31:20 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/5] arm: dts: sun8i: a83t: Add I2C0 node To: Maxime Ripard Cc: =?UTF-8?Q?Myl=C3=A8ne_Josserand?= , Rob Herring , Mark Rutland , Russell King , Chen-Yu Tsai , Dmitry Torokhov , "linux-input@vger.kernel.org" , simon.budig@kernelconcepts.de, linux-kernel , devicetree , linux-arm-kernel , Thomas Petazzoni Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1137 Lines: 37 On Mon, Dec 11, 2017 at 3:15 PM, Maxime Ripard wrote: > Hi, > > On Fri, Dec 08, 2017 at 10:54:15PM +0100, Mylène Josserand wrote: >> Add I2C0 node for A83T. >> >> Signed-off-by: Mylène Josserand >> --- >> arch/arm/boot/dts/sun8i-a83t.dtsi | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi >> index 19acae1b4089..848cf3f19962 100644 >> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi >> @@ -177,6 +177,17 @@ >> #dma-cells = <1>; >> }; >> >> + i2c0: i2c@01c2ac00 { > > Drop the leading 0, it generates a warning in dtc. > >> + compatible = "allwinner,sun6i-a31-i2c"; > > Can you add a SoC-specific compatible there please? > >> + reg = <0x01c2ac00 0x400>; > > And you should order your nodes by physical address. I have a similar patch in my A83T I2S branch: https://github.com/wens/linux/commit/8b76a3e555b39a06f3f8182e4ff5645de4c4cbc3 ChenYu