Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752500AbdLKJHe (ORCPT ); Mon, 11 Dec 2017 04:07:34 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:34922 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbdLKJHc (ORCPT ); Mon, 11 Dec 2017 04:07:32 -0500 X-Google-Smtp-Source: AGs4zMafBqjDq+WThYJq1gssu4H4622kpZ9V8NlrcHcPuyaI6Vn+nopJItZqh9SrjeeHX9uAQYiDj3TRT/yuahIAKb0= MIME-Version: 1.0 In-Reply-To: <1512943833-31352-3-git-send-email-david@lechnology.com> References: <1512943833-31352-1-git-send-email-david@lechnology.com> <1512943833-31352-3-git-send-email-david@lechnology.com> From: Philippe Ombredanne Date: Mon, 11 Dec 2017 10:06:50 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] drm/tinydrm: add driver for ST7735R panels To: David Lechner Cc: dri-devel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , limor@ladyada.net, Linus Walleij , Rob Herring , Mark Rutland , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1173 Lines: 36 David, On Sun, Dec 10, 2017 at 11:10 PM, David Lechner wrote: > This adds a new driver for Sitronix ST7735R display panels. > > This has been tested using an Adafruit 1.8" TFT. > > Signed-off-by: David Lechner > --- /dev/null > +++ b/drivers/gpu/drm/tinydrm/st7735r.c > @@ -0,0 +1,219 @@ > +/* > + * DRM driver for Sitronix ST7735R panels > + * > + * Copyright 2017 David Lechner > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + */ Have you considered using the new SPDX ids? Check the doc patches from Thomas for details. This could come out this way if you are using the C++ comment style all the way, a style that you should at least use for the license id as requested and commented by Linus: > +// SPDX-License-Identifier: GPL-2.0+ > +// Copyright 2017 David Lechner > +// DRM driver for Sitronix ST7735R panels -- Cordially Philippe Ombredanne