Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752673AbdLKJTv (ORCPT ); Mon, 11 Dec 2017 04:19:51 -0500 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:57628 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752624AbdLKJTn (ORCPT ); Mon, 11 Dec 2017 04:19:43 -0500 Date: Mon, 11 Dec 2017 10:18:05 +0100 From: Florian Westphal To: Colin King Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S . Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][netfilter-next] netfilter: conntrack: make struct nf_conntrack_l4proto_gre4 static Message-ID: <20171211091805.GK24449@breakpoint.cc> References: <20171210233255.15009-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171210233255.15009-1-colin.king@canonical.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 515 Lines: 14 Colin King wrote: > From: Colin Ian King > > The structure nf_conntrack_l4proto_gre4 is local to the source and does > not need to be in global scope, so make it static. This bug was added in commit b9679a9fd3a7d36ea3deb2864a00cc413c5aae28 netfilter: conntrack: l4 protocol trackers can be const > -struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = { > +static struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = { This should be 'static const'.