Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752632AbdLKJUF (ORCPT ); Mon, 11 Dec 2017 04:20:05 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:35076 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752525AbdLKJT5 (ORCPT ); Mon, 11 Dec 2017 04:19:57 -0500 X-Google-Smtp-Source: AGs4zMZtlGjkB4NGi23hsFNMvBKM7eryo6KgKkuYwzf17LsO6WmuG8dXRKWv52pCTvv6ZjCS2Pm92JvI6AUShs0hTQs= MIME-Version: 1.0 In-Reply-To: <1512979049-15930-3-git-send-email-hayashi.kunihiko@socionext.com> References: <1512979049-15930-1-git-send-email-hayashi.kunihiko@socionext.com> <1512979049-15930-3-git-send-email-hayashi.kunihiko@socionext.com> From: Philippe Ombredanne Date: Mon, 11 Dec 2017 10:19:15 +0100 Message-ID: Subject: Re: [PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver To: Kunihiko Hayashi Cc: "David S. Miller" , netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Rob Herring , Mark Rutland , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Masahiro Yamada , Masami Hiramatsu , Jassi Brar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2011 Lines: 59 Dear Kunihiko-san, On Mon, Dec 11, 2017 at 8:57 AM, Kunihiko Hayashi wrote: > The UniPhier platform from Socionext provides the AVE ethernet > controller that includes MAC and MDIO bus supporting RGMII/RMII > modes. The controller is named AVE. > > Signed-off-by: Kunihiko Hayashi > Signed-off-by: Jassi Brar > Reviewed-by: Andrew Lunn [...] > --- /dev/null > +++ b/drivers/net/ethernet/socionext/Makefile > @@ -0,0 +1,5 @@ > +# SPDX-License-Identifier: GPL-2.0 You are correctly using SPDX ids here.... > +obj-$(CONFIG_SNI_AVE) += sni_ave.o > diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c > new file mode 100644 > index 0000000..7b293c2 > --- /dev/null > +++ b/drivers/net/ethernet/socionext/sni_ave.c > @@ -0,0 +1,1744 @@ > +/** > + * sni_ave.c - Socionext UniPhier AVE ethernet driver > + * > + * Copyright 2014 Panasonic Corporation > + * Copyright 2015-2017 Socionext Inc. > + * > + * This program is free software: you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 of > + * the License as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ ... then I guess you could also use them here, replacing at least 7 lines of boilerplate by a single id line? > +// SDPX-License-Identifier: GPL-2.0 And if you go C++ style all the way, this could be even more compact: > +// SDPX-License-Identifier: GPL-2.0 > +// sni_ave.c - Socionext UniPhier AVE ethernet driver > +// Copyright 2014 Panasonic Corporation > +// Copyright 2015-2017 Socionext Inc. Thank you for your kind consideration! -- Cordially Philippe Ombredanne